-
-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSX's python 2.7.10 interpreter reports a bad local platform, bdists fail to resolve #523
Labels
Comments
Found in pantsbuild/pants#6104 |
jsirois
added a commit
to pantsbuild/pants
that referenced
this issue
Jul 13, 2018
Previously the platform passed for 'current' was partial, leading to ambiguous resolves. Further, partial platforms in user's BUILD files also would lead to ambiguous resolves. For example, a multi-platform `python_binary` with something like `platforms=['current', 'linux-x86_64', 'macosx_10.11_x86_64']`. Expand and and then fixup platforms as required by replacing `get_local_platform` with `expand_and_maybe_adjust_platform`. Also perform a few `build_local_python_distributions` fixes. + Fix an unused `interpreter` parameter - forward to `SetupPyRunner`. + Kill declaring `--universal` on behalf of the package author. There is not enough info to make the decision if the code being dist'd, if pure python, is 2/3 compatible. To compensate for the removal of `--universal`, give an example of how to declare your python_dist as `--universal` when you know it is as the BUILD `python_dist` target author. Finally two subsidary workarounds: + hack around PEX not forwarding custom interpreters to PEXEnvironment. + Avoid the troublesome Apple 2.7.10 python for now. Hacks are tracked by umbrella #5922, but for this PR they are: + pex-tool/pex#511 + pex-tool/pex#522 + pex-tool/pex#523
This was referenced Sep 24, 2018
Closed
Closed
jsirois
added a commit
to jsirois/pex
that referenced
this issue
Oct 1, 2018
jsirois
added a commit
to jsirois/pex
that referenced
this issue
Oct 1, 2018
Have this use pex intrinsics instead of pkg_resources which is known to report bad values on Apple-shipped inerpreters. Fixes pex-tool#523
jsirois
added a commit
to jsirois/pex
that referenced
this issue
Oct 1, 2018
jsirois
added a commit
to jsirois/pex
that referenced
this issue
Oct 1, 2018
Have this use pex intrinsics instead of pkg_resources which is known to report bad values on Apple-shipped inerpreters. Fixes pex-tool#523
jsirois
added a commit
to jsirois/pex
that referenced
this issue
Oct 1, 2018
Have this use pex intrinsics instead of pkg_resources which is known to report bad values on Apple-shipped inerpreters. Fixes pex-tool#523
jsirois
added a commit
to jsirois/pex
that referenced
this issue
Oct 1, 2018
Have this use pex intrinsics instead of pkg_resources which is known to report bad values on Apple-shipped inerpreters. Fixes pex-tool#523
jsirois
added a commit
to jsirois/pex
that referenced
this issue
Oct 2, 2018
Have this use pex intrinsics instead of pkg_resources which is known to report bad values on Apple-shipped inerpreters. Fixes pex-tool#523
jsirois
added a commit
to jsirois/pex
that referenced
this issue
Oct 2, 2018
Have this use pex intrinsics instead of pkg_resources which is known to report bad values on Apple-shipped inerpreters. Also fix resolver extended platform determination to support the test for the fix. Fixes pex-tool#511 Fixes pex-tool#523
jsirois
added a commit
to jsirois/pex
that referenced
this issue
Oct 3, 2018
Have this use pex intrinsics instead of pkg_resources which is known to report bad values on Apple-shipped inerpreters. Also fix resolver extended platform determination to support the test for the fix. Fixes pex-tool#511 Fixes pex-tool#523
jsirois
added a commit
that referenced
this issue
Oct 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In particular, under the OSX system 2.7.10 / xcode 8.3 (on TravisCI), the reported platform is
macosx-10.12-intel
and the resulting calculated tags are:Easier to digest, and sorted, that's PEXEnvironment reported supported tag for interpreter:
PythonInterpreter(
'/System/Library/Frameworks/Python.framework/Versions/2.7/Resources/Python.app/Contents/MacOS/Python',
PythonIdentity('CPython', 2, 7, 10) ...)
And
pkg_resources.Environmentf
's default calculation of 'macosx-10.12-intel' as the platform:It seems pex should hack support for this or fail fast if it see this sort of platform.
The text was updated successfully, but these errors were encountered: