Fixed TypeError using readline with spawnu #67
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| strings. | ||
| """ | ||
| child = pexpect.spawnu(ECHO, [ "foobar"]) | ||
| foobar = child.readline() |
There was a problem hiding this comment.
Can you make this a proper test case - i.e. it shouldn't run on import. I'd probably put it in test_unicode as well, rather than making a new file for it.
|
I implemented the changes you suggested. I also added a test for spawn() in addition to spawnu(). I tested it on both python2.7 and python3.4, but let me know if there are any errors in the string types. I'll admit they continue to confuse me in python. |
|
Thank you! Added to doc/history.rst and split spawn() tests beside its neighbors in test_misc.py. merge --squashed as commit 8aea7dd |
jquast
referenced
this pull request
Jun 9, 2014
Submitted by @auntieNeo, fixes exception, "TypeError: got <type 'str'> ('\r\n') as pattern" in spawnu.readline(). Bytes b'\r\n' was concatenated to u'unicode', causing an exception to be thrown when using readline().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be a bug in the spawn.readline() function that makes it impossible to use with spawnu objects (i.e. when using strings rather than bytes). I wrote a small patch that fixes this. I tested with Python 3.2 on cygwin. I also included a small test that can reproduce this bug.