Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A minor issue found via static analysis #35

Closed
tzickel opened this issue Dec 13, 2016 · 1 comment
Closed

A minor issue found via static analysis #35

tzickel opened this issue Dec 13, 2016 · 1 comment

Comments

@tzickel
Copy link

tzickel commented Dec 13, 2016

ExceptionPexpect is not defined.

ptyprocess/ptyprocess/_fork_pty.py

Line 66 in 8f1ba73

raise ExceptionPexpect("OSError of errno.ENXIO should be raised.")

Found using cython and
https://gist.github.com/tzickel/ea4541b12c1298a8092c3ec5043ef77e

pip install -I --root temp_ptyprocess ptyprocess
python checkcython.py temp_ptyprocess
takluyver added a commit to takluyver/ptyprocess that referenced this issue Dec 13, 2016
@takluyver
Use PtyProcessError instead of ExceptionPexpect
f673a54 
Closes pexpectgh-35
@takluyver takluyver mentioned this issue Dec 13, 2016
Merged
@takluyver
Copy link
Member

Thanks! #36 should fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@takluyver @tzickel