Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bamtools resolve removes quality string? #68

Closed
ekg opened this issue Dec 7, 2012 · 3 comments
Closed

bamtools resolve removes quality string? #68

ekg opened this issue Dec 7, 2012 · 3 comments

Comments

@ekg
Copy link

ekg commented Dec 7, 2012

I have some simulated reads which I've aligned with Mosaik, then sorted. At a certain point I realized that the reason that samtools wasn't calling anything from the data was that it only works on proper pairs, so I added bamtools resolve into my pipeline. The result seems to make GATK unhappy sometimes. It notes that there are no quality bases attached to a particular read.

This is what happens to the read. Before:

% bamtools merge -in sample06.bam | samtools view - | grep sample06.000003491
# first mate
sample06.000003491      145     chr20_bit       2124    65      1S69M   =       1796    -396    GTTTGATGGGTGAGTGCACTGTAACTTCCAGACGTCTCTTGGTAGGTGGGCCCCACTGGCCAAGGGCATT  *AIIICFII>IIGDIHIIIIIEIDIIIIDEIHGGIEHEFIIIIDGHHIIEIHIGIIHHGIHHHIHIHHHH    RG:Z:sample06   NM:i:0  MD:Z:69 ZA:Z:<&;63;0;;1;70M;70><@;61;0;;1;;>
% bamtools resolve -twoPass -in sample06.bam | samtools view - | grep sample06.000003491
# first mate unaffected
sample06.000003491      147     chr20_bit       2124    65      1S69M   =       1796    -396    GTTTGATGGGTGAGTGCACTGTAACTTCCAGACGTCTCTTGGTAGGTGGGCCCCACTGGCCAAGGGCATT  *       RG:Z:sample06     NM:i:0  MD:Z:69 ZA:Z:<&;63;0;;1;70M;70><@;61;0;;1;;>

I can deliver a full test case off-thread.

@pezmaster31
Copy link
Owner

Ah, I'll bet you anything the bug is with the leading '*' character in the quality string, getting interpreted a la SAM ('missing'). I'll take a look at it this weekend. Thanks for the heads-up.

@ekg
Copy link
Author

ekg commented Dec 7, 2012

That looks like the problem. I think I can work around it for now. Glad
you've already been informed.

On Fri, Dec 7, 2012 at 11:15 PM, Derek Barnett notifications@github.comwrote:

Ah, I'll bet you anything the bug is with the leading '*' character in the
quality string, getting interpreted a la SAM ('missing'). I'll take a look
at it this weekend. Thanks for the heads-up.


Reply to this email directly or view it on GitHubhttps://github.com//issues/68#issuecomment-11148761.

ekg added a commit to ekg/bamtools that referenced this issue Dec 7, 2012
Check that the quality string is fully comprised of "*", rather than if
the first character is "*".
@ekg
Copy link
Author

ekg commented Dec 7, 2012

If the fix in my repository doesn't have unintended side-effects, it should be sufficient to resolve this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants