FactoryGirl: rspec--include-fg-syntax-methods-p #117
Comments
|
Sure, why not? |
|
@dgutov great! I'll see if I can tackle this over the next few days. |
imtayadeway
added a commit
to imtayadeway/rspec-mode
that referenced
this issue
Apr 27, 2015
More recent versions of rspec-rails create/recommend creating both a `rails_helper.rb` and `spec_helper.rb` file, with the intention of putting rails-specific configuration in the former. Given that a rails project is set up in this way, including the syntax methods for factory girl would be expected to go into the rails helper. This change looks in the rails helper if it exists first before searching the spec helper for the inclusion of this module. pezra#117
imtayadeway
added a commit
to imtayadeway/rspec-mode
that referenced
this issue
Apr 29, 2015
More recent versions of rspec-rails create/recommend creating both a `rails_helper.rb` and `spec_helper.rb` file, with the intention of putting rails-specific configuration in the former. Given that a rails project is set up in this way, including the syntax methods for factory girl would be expected to go into the rails helper. This change looks in the rails helper if it exists first before searching the spec helper for the inclusion of this module. pezra#117
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Just noticed that this checks the spec helper for
FactoryGirl::Syntax::Methods. More recent versions of rspec-rails will create aspec_helper.rbandrails_helper.rbfile, and the appropriate place for putting this include is in the latter. Should the rails helper also be checked (assuming of course that it's a rails project, and that the rails helper is there)?The text was updated successfully, but these errors were encountered: