Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update slf4j #271

Merged
merged 2 commits into from
Jan 3, 2019
Merged

Update slf4j #271

merged 2 commits into from
Jan 3, 2019

Conversation

pinhead84
Copy link
Contributor

PF4J currently uses a pretty old version of SLF4J. Therefore I'm suggesting to update from version 1.7.5 to 1.7.25. Take a look at their news page to find out more about modifications.

My application already uses PF4J together with SLF4J and Log4J without any issues. I wouldn't expect any problem for other users. But of course feel free to test it for yourself. ;)

@coveralls
Copy link

coveralls commented Jan 3, 2019

Pull Request Test Coverage Report for Build 443

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 54.652%

Totals Coverage Status
Change from base Build 438: 0.09%
Covered Lines: 887
Relevant Lines: 1623

💛 - Coveralls

@decebals decebals merged commit 7e8c7fe into pf4j:master Jan 3, 2019
@decebals
Copy link
Member

decebals commented Jan 3, 2019

Thanks!

@pinhead84 pinhead84 deleted the update-slf4j branch March 23, 2019 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants