-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade dependencies (enable Symfony 6 support), fix some tests #11
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Symgony 6 have not been fully implemented(some deps still ^4.0| ^5.0).
- Introduced mixed type-hints set strict php8 requirements, but the php7 requirement remains in the composer.json
"symfony/orm-pack": "*", | ||
"symfony/twig-bundle": "^4.0 || ^5.0", | ||
"symfony/dependency-injection": "^4.0 || ^5.0", | ||
"symfony/dependency-injection": "^4.0 || ^5.0 || ^6.0", | ||
"symfony/config": "^4.0 || ^5.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missed ^6 version here
@@ -24,23 +25,23 @@ | |||
"require": { | |||
"php": ">=7.1", | |||
"ext-pdo": "*", | |||
"symfony/framework-bundle": "^4.0 || ^5.0", | |||
"symfony/framework-bundle": "^4.0 || ^5.0 || ^6.0", | |||
"symfony/orm-pack": "*", | |||
"symfony/twig-bundle": "^4.0 || ^5.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missed ^6 version here
@@ -49,7 +49,7 @@ public final function setIdentifier($identifier) | |||
* @return boolean true on success or false on failure. | |||
* The return value will be casted to boolean if non-boolean was returned. | |||
*/ | |||
public final function offsetExists($offset) | |||
public final function offsetExists(mixed $offset): bool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mixed type-hint support added in PHP8, but in composer.json still PHP7.1 support
@@ -56,7 +56,7 @@ protected function setUp(): void | |||
static::$kernel->getContainer()->get('router'), | |||
static::$kernel->getContainer()->get('twig'), | |||
$stack, | |||
static::$kernel->getContainer()->get('translator') | |||
// static::$kernel->getContainer()->get('translator') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please no commented code its a bad practice
Thanks for the review and the comments, I should have probably marked this as a draft, as I have now. Until all tests are fixed, though that might yet take some time. |
No description provided.