Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate actual error message in tests #181

Merged
merged 2 commits into from Apr 2, 2019
Merged

Validate actual error message in tests #181

merged 2 commits into from Apr 2, 2019

Conversation

dtaniwaki
Copy link
Contributor

I updated the tests so we can validate error messages.

@dtaniwaki dtaniwaki requested a review from ordovicia April 2, 2019 08:17
@dtaniwaki
Copy link
Contributor Author

I pushed wrong commits so I rollbacked them.

@dtaniwaki
Copy link
Contributor Author

I'll resolve the conflicts.

ordovicia
ordovicia approved these changes Apr 2, 2019
View reviewed changes
Copy link
Collaborator

@ordovicia ordovicia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ordovicia ordovicia merged commit 70d22d7 into master Apr 2, 2019
@ordovicia ordovicia deleted the error-tests branch April 7, 2019 08:12
@ordovicia ordovicia added enhancement Category: Enhancement on existing features test Area: Testing of this project labels Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ordovicia ordovicia ordovicia approved these changes

Assignees
No one assigned
Labels
enhancement Category: Enhancement on existing features test Area: Testing of this project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtaniwaki @ordovicia