Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement MGU #1101

Merged
merged 9 commits into from Aug 7, 2017
Merged

Implement MGU #1101

merged 9 commits into from Aug 7, 2017

Conversation

unnonouno
Copy link
Member

I implemented Minimal Gated Unit.
http://arxiv.org/abs/1603.09420

@delta2323 delta2323 added the cat:feature Implementation that introduces new interfaces. label Apr 12, 2016
@unnonouno unnonouno changed the title [WIP] Implement MGU Implement MGU May 25, 2016
@delta2323
Copy link
Member

Do you think we should explicitly name StatelessMGU instead of MGU in the same as LSTM?

delta2323
delta2323 reviewed May 31, 2016
View reviewed changes
chainer/links/connection/mgu.py Outdated
def set_state(self, h):
assert isinstance(h, chainer.Variable)
h_ = h
if self.xp == numpy:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use is to compare modules.

@delta2323 delta2323 self-assigned this May 31, 2016
@delta2323 delta2323 mentioned this pull request May 31, 2016
Closed
@unnonouno
Copy link
Member Author

We need to make a policy about names of RNN algorithms first.

@delta2323 delta2323 mentioned this pull request Jun 14, 2016
Closed
@delta2323 delta2323 mentioned this pull request Jun 27, 2016
Merged
@delta2323 delta2323 mentioned this pull request Jul 30, 2016
Closed
delta2323
delta2323 reviewed Aug 1, 2016
View reviewed changes
chainer/links/connection/mgu.py Outdated
return h_new


class StatefulMGU(MGU):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It have the same problem as one in SGD and DSGU in #1115. StatefulMGU may not be the subclass of MGU.

@delta2323
Copy link
Member

@unnonouno How about changing the name from SGU to StatelessSGU so that we can create the alias SGU afterwards? We can merge this PR once we determine the names.

@delta2323 delta2323 mentioned this pull request Dec 5, 2016
Closed
@delta2323
Copy link
Member

As the naming rule of RNN modules is determined. We can merge this PR. Could you resolve the conflict?

@niboshi
Copy link
Member

niboshi commented Jul 28, 2017

Resolved conflict and rewrote to use use_scope.

@delta2323
Copy link
Member

jenkins, test this please.

@delta2323
Copy link
Member

test passed

@delta2323 delta2323 merged commit 868971e into master Aug 7, 2017
@delta2323 delta2323 deleted the mgu branch August 7, 2017 05:18
@delta2323 delta2323 added this to the v3.0.0rc1 milestone Aug 7, 2017
hvy added a commit that referenced this pull request Nov 29, 2018
@hvy
Merge pull request #1101 from pfnet/disable-pytest-output
217f0bb 
Remove pytest --capture=no option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@delta2323 delta2323

Labels
cat:feature Implementation that introduces new interfaces.
Projects
None yet
Milestone
v3.0.0rc1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@unnonouno @delta2323 @niboshi