-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ready] Fix _ObjectReader.seek(0, os.SEEK_END)
case
#242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/test |
Successfully created a job for commit 27aa610: |
1 similar comment
Successfully created a job for commit 27aa610: |
27aa610
to
14d1dba
Compare
/test Thanks for contribution! LGTM |
Successfully created a job for commit 14d1dba: |
1 similar comment
Successfully created a job for commit 14d1dba: |
kuenishi
approved these changes
Dec 22, 2021
_ObjectReader.seek(0, os.SEEK_END)
case_ObjectReader.seek(0, os.SEEK_END)
case
/test |
Successfully created a job for commit 42b9d20: |
|
_ObjectReader.seek(0, os.SEEK_END)
case_ObjectReader.seek(0, os.SEEK_END)
case
/test |
Successfully created a job for commit eb422cd: |
1 similar comment
Successfully created a job for commit eb422cd: |
_ObjectReader.seek(0, os.SEEK_END)
case_ObjectReader.seek(0, os.SEEK_END)
case
kuenishi
approved these changes
Dec 23, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It addresses #239
This PR fixes the inconsistent behavior of
seek
when opening a file on S3.Fixing only the above case is enough to fix the issue reported in #239.
But for better transparency of pfio API with other types of filesystems, I updated the whole
seek
behavior to work identically to normal file-like objects returned byopen
(binary mode).