Add __repr__ to FS classes #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuenishi
requested changes
Aug 30, 2023
There was a problem hiding this comment.
Thank you, that's wonderful suggestion and this is what I really wanted. I want to merge it so hard but also I want to keep the code under the principle of "no util" to prevent it being source of mess in the near future. c.f. https://mykeels.medium.com/utils-are-a-blackhole-c8320968325b
https://dev.to/dvddpl/utils-files-are-not-so-useful-and-helper-classes-are-not-so-helpful-1kfn
pfio/v2/_utils.py
Outdated
| from typing import Any, Dict, Type | ||
|
|
||
|
|
||
| def format_repr(cls: Type, data: Dict[str, Any]) -> str: |
There was a problem hiding this comment.
I want this function included in the tail of fs.py to obey the no-util principle.
There was a problem hiding this comment.
Thank you for the commend. Fixed: 3146828
kuenishi
added
the
cat:enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be convenient if some information was included in
repr.↓