Add interface to trace events in custom runtimes #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emcastillo
commented
Aug 4, 2022
| @@ -311,6 +311,17 @@ def map( | |||
| """ | |||
| raise NotImplementedError() | |||
|
|
|||
| @classmethod | |||
| @contextlib.contextmanager | |||
| def trace(cls, event_name: str, arg: Any) -> Generator[None, None, None]: | |||
There was a problem hiding this comment.
This is a class method since we can have multiple runtime instances (one per module created with ppe.to). I think we should address these issues in other PR since the ppe.to and nested modules semantics changed and can be tricky.
emcastillo
force-pushed
the
add-profile-interface
branch
from
415a591
to
7d3d518
Compare
added 2 commits
August 15, 2022 02:46
emcastillo
commented
Aug 15, 2022
| @@ -218,6 +218,8 @@ def run(self, | |||
| self._train_len = train_len | |||
| self._eval_len = eval_len | |||
|
|
|||
| device = self.handler._entry_runtime.device_spec # type: ignore[attr-defined] | |||
There was a problem hiding this comment.
wonder if we should pass the device spec as a trainer arg instead of accessing it like this. It would be much simpler.
|
Sorry for the delay, LGTM! |
kmaehashi
approved these changes
Dec 13, 2022
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.