Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using pkg_resources #824

Merged
merged 4 commits into from
Jul 24, 2024
Merged

Avoid using pkg_resources #824

merged 4 commits into from
Jul 24, 2024

Conversation

asi1024
Copy link
Member

@asi1024 asi1024 commented Jul 24, 2024

@linshokaku
Copy link
Member

linshokaku commented Jul 24, 2024 •
edited
Loading

How about rewriting get_distribution().version to use import_lib.metadata.version() instead, which is available from Python 3.8+?

https://docs.python.org/ja/3/library/importlib.metadata.html

@linshokaku
Copy link
Member

/test

linshokaku
linshokaku approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@linshokaku linshokaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@linshokaku linshokaku merged commit 785dc7a into pfnet:master Jul 24, 2024
22 checks passed
@asi1024 asi1024 deleted the avoid_pkg_resources branch July 24, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linshokaku linshokaku linshokaku approved these changes

@kmaehashi kmaehashi Awaiting requested review from kmaehashi kmaehashi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asi1024 @linshokaku