A first take at attempting to pass stream handles through IPC #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
than stream objects. It's possible that all objects should be proxied that are class instances.
|
Thanks for the PR! I think we need to look at the streams interface that's being exported, which is a PITA. For web-facing APIs, we probably need to use WHATWG streams, right? |
|
Yes, but I think it will be pretty simple - though you'd know better than I would. It seems like we could just replace 'new Readable' on the import side with 'new ReadableStream' and the appropriate callbacks. The other question is whether that translation should happen in the RPC lib or in Beaker (since it's the one that's actually mimicking Web APIs.) Maybe Beaker needs to be given some further hooks into the RPC layer for object translation - like the permissions hook. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible that all objects should be proxied that are class instances.