Make suggest-box smarter about placement on the screen #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the box to the left to prevent it from being overflowing the viewport on the right. Don't move it too far that it overflows the viewport on the left. Make this adjustment every time the box updates its options.
- Fill textarea with newlines to make it quicker to test completion towards the bottom of the viewport. - Add a checkbox to toggle right-alignment, to make it easier to test completion towards the right of the viewport.
clehner
force-pushed
the
stay-in-viewport
branch
from
b78850d
to
94f010a
Compare
|
I don't have time to test, if you're confident this is 👍 I'll do a blind merge |
|
Sounds good. Want to add me as collaborator/maintainer?
|
|
Nah I can publish |
|
Published 2.2.3 |
|
Cool, thanks
|
|
@pfrazee what I eventually figured out is always be adding people because one day you won't care about the module any more, and by then it will be hard to find someone to take it over. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes make suggest-box more useful when the textarea is close to the bottom and/or right of the viewport.