Adding support for Google Authenticator #196
Conversation
|
Something missing for merge? |
There was a problem hiding this comment.
Other than inline commented items, since you are adding a python script, you need to have all dependencies (python + possible python modules) covered so those items will be installed when freeradius2 package is installed. You can see some examples about how to deal with python options on ports at:
https://www.freebsd.org/doc/en/books/porters-handbook/book.html#using-python
And last, please bump PORTREVISION so a new package can be built
| // Install Google Authenticator scripts | ||
| if (!file_exists(FREERADIUS_ETC . "/raddb/scripts/googleauth.py")) { | ||
| copy(FREERADIUS_BASE . "/pkg/googleauth.py", FREERADIUS_ETC . "/raddb/scripts/"); | ||
| exec("chmod +x " . FREERADIUS_ETC . "/raddb/scripts/googleauth.py"); |
There was a problem hiding this comment.
PHP provides a function to chmod(), consider using it
| @@ -0,0 +1,57 @@ | |||
| #!/usr/local/bin/python2.7 | |||
There was a problem hiding this comment.
Is this code yours? It's missing license and copyright
There was a problem hiding this comment.
Some code is from here:
http://www.brool.com/post/using-google-authenticator-for-your-website/
License is "CC0 1.0 Universal License"
Use PHP chmod() function
Added Copyright and License
There was a problem hiding this comment.
Why not install googleauth and googleauth.py direct into FREERADIUS_ETC/raddb/modules and FREERADIUS_ETC/raddb/modules and remove the need of copy those files around? The way it is implemented if you update one of those files they will never replaced the previous copied file and new version will never be used.
Other than that, it's missing changes on port Makefile:
- Add python dependency
- Add code to get new files installed
- Add googleauth.py to the list of files to USE_SHEBANG so shebang line is changed using correct python path
- Bump PORTREVISION or PORTVERSION to build a new package
| copy(FREERADIUS_BASE . "/pkg/googleauth.py", FREERADIUS_ETC . "/raddb/scripts/"); | ||
| chmod(REERADIUS_ETC . "/raddb/scripts/googleauth.py",0755); | ||
| } | ||
| if (!file_exists(FREERADIUS_ETC . "/raddb/modules/googleauth")) { copy(FREERADIUS_BASE . "/pkg/googleauth", FREERADIUS_ETC . "/raddb/modules/");} |
There was a problem hiding this comment.
Please break this long line as is done on block just above it
|
Hey there, Greetings |
|
The latest development branch breaks the GoogleAuth support, because the requirement for the Init-Secret is "Note: May only contain 0-9 and a-f. Must contain at least 16 characters." ! |
From ChangeLog: https://github.com/TheLocehiliosan/yadm/releases/tag/2.4.0 Update version number and update documentation * Support multiple keys in `yadm.gpg-recipient` (#139) * Ensure all templates are written atomically (#142) * Add encrypt_with_checksums to the hooks collection (#188) * Escape white space in YADM_HOOK_FULL_COMMAND (#187) * Improve parsing of os-release (#194) * Improve identification of WSL (#196) * Fix troff warnings emitted by man page (#195) * Write encrypt-based exclusions during decrypt PR: 244509 Submitted by: vendion@gmail.com (maintainer)
Changes since 0.1.1:
> This version has some breaking changes in the config file and, you will
need to regenerate the config for all features to work.
- The tool is now compatible with next-gen/team-managed project.
- New filters when listing issues, viz:
- Filter by parent: This will allow you to list all sub-tasks of a task.
- Order by filter: This will allow you to display a list sorted by their
rank for example.
- You can now assign epic to the issue on creation.
- You can add issues to the sprint with `jira sprint add`
- feat: Allow to assign epic on create #194
- feat: Cmd to add issues to sprint #205
- feat: Allow to filter by parent #197
- feat: Add order-by filter #206
- feat: Add type on project listing #190
- fix: Make epic add work in next-gen project #195
- fix: Epic creation for next-gen project #192
- fix: Make epic remove work in next-gen project #196
- fix: Make epic list work for next-gen project #201
- fix: Segmentation fault on view #202
- fix(tui): Link/key copy is broken for altered key col #204
- cfg!: Expand config to include project type #191
- cfg!: Rename field to name and add link field to epic #193
- dep: Upgrade rivo/tview #176
- dep: Upgrade outdated deps to latest #177
- dep: Use Go 1.17 #178
**Full Changelog**: ankitpokhrel/jira-cli@v0.1.1...v0.2.0
* 2.6.1 - use 'zu' format string in deduper_dump() (#196) - ctype.h functions require int arguments. cygwin gcc enforces this. Update version to 2.6.1 * 2.6.2 - fix three memory leaks revealed by valgrind (#202) - see if we can remove the need for res_rcode() by changing the error path (#200) - use strtok_r() in preference to strsep(), for consistency and modernity (#203) - based on PR 204, refactor and comment for clarity (#205) * 2.6.3 - replace strtok_r() by new tokstr library - tokstr_h was a typo, thanks to codereview.stackexchange.com for finding it - attempt to work around gcc11 structure size checks (#207) - tokstr regions (#208) - Revised fix for issue 209: "error: unknown type ssize_t; did you mean _ssize_t?" (#211) - Can now build on Apple M1 processors by following the instructions (#212) - Clarify that not all macOS M1 machines have homebrew in the new /opt/homebrew location - Document again the HTTPS_PROXY environment variable * 2.6.4 - Issue 214: batch option parsing bug in tokstr library changes. (#215) Sponsored by: DomainTools
Gives the possibility for a user to choose between mOTP and Google Authenticator in Freeradius, when using one-time-passwords.