Add LCDproc #178

Treer · 2016-08-25T15:38:26Z

308076b is a pfSense 2.3 ports package containing the original LCDproc files
at 7fe021f the conversion of the UI to use the new OO Forms system is finished
at 93f8cfa I've added 3 extra screens to take advantage of 4+ row LCDs

One of the extra screens is displaying the output of bandwidth_by_ip.php, but that file is designed for ajax calls so requires an authenticated session, so this LCDproc package has its own copy of that file which it can run locally in the usr/local/pkg directory, which seems unfortunate but necessary, perhaps someone has a better idea?

I've compiled and used this as a manually installed ports package in pfSense 2.3.1-RELEASE-p5 and 2.3.3-DEVELOPMENT, with the new UI and screens, but don't know how to test it with pfSense's package manager, and have not made a package for pfSense before.

This is built from the LCDproc-dev package as it's had more work and functionality added than LCDproc. LCDproc-dev was created to add early support for LCDProc 0.5.4 without affecting LCDproc, and since this port will be using LCDProc 0.5.7+, there's no need to keep maintaining two packages.

See https://redmine.pfsense.org/issues/5739

…sted by current traffic

Fixes bug where bps measurements stayed 0

Shows the same data as the list on the Traffic Graph screen - bandwidth by IP/host

Fix up some of the file heading comments

The label can go back to "Total today" once resetting the totals daily has been implemented.

The screen was showing totals since boot, so they are now seperate screens. Removed text describing the interface sort order, since this will be fixed if all interfaces can fit on screen.

Treer · 2016-09-08T15:50:19Z

hubba has also posted a fix for the CARP screen, I have included it in this pull request as it looks correct, but I don't have a CARP setup (or experience using CARP) so have not tested it.

https://redmine.pfsense.org/projects/pfsense/repository/revisions/2a5960b07bb2a40aeaf81423b0c52d5629e87e49 (Credit to hubba: https://forum.pfsense.org/index.php?topic=110177.msg652986#msg652986)

rbgarga · 2016-12-05T20:56:38Z

sysutils/pfSense-pkg-LCDproc/Makefile

+do-install:
+	${MKDIR} ${STAGEDIR}${PREFIX}/pkg
+	${MKDIR} ${STAGEDIR}/etc/inc/priv
+	${MKDIR} ${STAGEDIR}${PREFIX}/www/packages/lcdproc	


Whitespace before EOL, please remove

rbgarga · 2016-12-05T20:56:50Z

sysutils/pfSense-pkg-LCDproc/Makefile

+MAINTAINER=	coreteam@pfsense.org
+COMMENT=	LCDproc package for pfSense
+
+LICENSE=	ESF


We moved from ESF to APACHE20 license

rbgarga · 2016-12-05T20:58:49Z

sysutils/pfSense-pkg-LCDproc/files/etc/inc/priv/lcdproc.priv.inc

+	INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+	CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+	ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+	POSSIBILITY OF SUCH DAMAGE.


Change license text to APACHE20

rbgarga · 2016-12-05T20:59:05Z

sysutils/pfSense-pkg-LCDproc/files/usr/local/pkg/lcdproc.xml

+	ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+	POSSIBILITY OF SUCH DAMAGE.
+*/
+/* ====================================================================================== */


Please fix license text

rbgarga · 2016-12-05T20:59:20Z

sysutils/pfSense-pkg-LCDproc/files/usr/local/pkg/lcdproc.xml

+	</copyright>
+	<title>Services: LCDproc</title>
+	<name>lcdproc</name>
+	<version>0.10.3</version>


Change 0.10.3 to %%PKGVERSION%% knob

rbgarga · 2016-12-05T20:59:45Z

sysutils/pfSense-pkg-LCDproc/Makefile

+	${INSTALL_DATA} ${FILESDIR}${DATADIR}/info.xml \
+		${STAGEDIR}${DATADIR}
+	@${REINPLACE_CMD} -i '' -e "s|%%PKGVERSION%%|${PKGVERSION}|" \
+		${STAGEDIR}${DATADIR}/info.xml


Add all XML files that use %%PKGVERSION%% knob to this REINPLACE_CMD statement

rbgarga · 2016-12-05T21:00:25Z

sysutils/pfSense-pkg-LCDproc/files/usr/local/www/packages/lcdproc/lcdproc_screens.php

+	INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+	CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+	ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+	POSSIBILITY OF SUCH DAMAGE.


Fix license text

rbgarga · 2016-12-05T21:01:49Z

sysutils/pfSense-pkg-LCDproc/pkg-plist

+www/packages/lcdproc/lcdproc_screens.php
+www/packages/lcdproc/index.php
+%%DATADIR%%/info.xml
+@dir /etc/inc/priv


It's missing @dir /etc/inc here

First part of changes requested by rbgarga

Second part of changes requested by rbgarga

Treer · 2016-12-10T07:10:51Z

Changes performed.

I think GitHub's "View Changes" function (or whatever you used) collapsed 3 of the larger files, causing them to be overlooked. They also needed license text fixed:

sysutils\pfSense-pkg-LCDproc\files\usr\local\pkg\lcdproc_client.php
sysutils\pfSense-pkg-LCDproc\files\usr\local\pkg\lcdproc.inc
sysutils\pfSense-pkg-LCDproc\files\usr\local\www\packages\lcdproc\lcdproc.php

I've fixed the license text for those 3 in the last commit - ad76a83

rbgarga · 2016-12-14T13:54:11Z

Added to 2.4.0 and 2.3.3 snapshots. After more people test it and it's ready, we can add to 2.3.2

Treer · 2017-01-26T03:21:42Z

By copying the files from the old package into this new ports package, I've managed to lose their git histories.

Is it possible to get the git commit message of this commit amended to include some sort of link to the git repo the files came from?

Changes since 1.5.3: Interface: * A redesigned interface that works better for smaller screens (#176) * Improved fullscreen mode with an overlaid headerbar (#4) * The headerbar and the progress bar now auto-hide, for a distraction-free reading experience * Various location information, as well as a clock, can now be displayed in the footer (#175, #233) * A new location popover (Ctrl + L) that shows reading time estimates and allows skipping to locations (#155) * E-reader style navigation: go to the previous or next page by tapping on the left or right part of the view; tap on the middle to toggle header bar and progress bar * Annotations, bookmarks, and find results now show chapter titles (#162) * When looking up words in dictionaries, the query can now be edited (#156) * New shortcut for viewing metadata (Ctrl + I) and preferences (Ctrl + ,) * A new traditional menubar, which may be displayed depending on the desktop environment * Option to use a traditional titlebar and menubar instead of a headerbar (experimental) Reading: * Continuous scrolling layout * Option to show decorative shadows that mimic the appearance of a real book * Ability to zoom in and zoom out (#117) * Improved image viewer with "save as" option * Open copies of a book in new windows (Ctrl + N) * Reload book (Ctrl + R) * New built-in themes: Gray, Solarized, Gruvbox, Nord Text selection: * Ability to select text across pages * Find selected text in book * Speak selected text or from the selected location (#141) Annotations: * Spellcheck notes (requires new optional dependency "gspell") * Export annotations to Markdown (#180) * Options to use custom colors for highlights For publishers and developers: * Support for Apple Books theme attribute, which allows books to detect themes without JavaScript (#178) * WebKit's developer tools can be enabled Breaking changes: * The settings schemas has been reorganized * The format for custom themes has changed * Locations are now 1024 characters in size Bug fixes: * Fixed not restoring exact last location * Fixed navigation not working with scrolled layout * Fixed font size not changing when the book uses absolute-size keywords (#173) * Fixed text cut off at margin edge (#177) * Fixed unable to open books with "#" or "?" in the file name

Changes since 0.1.1: > This version has some breaking changes in the config file and, you will need to regenerate the config for all features to work. - The tool is now compatible with next-gen/team-managed project. - New filters when listing issues, viz: - Filter by parent: This will allow you to list all sub-tasks of a task. - Order by filter: This will allow you to display a list sorted by their rank for example. - You can now assign epic to the issue on creation. - You can add issues to the sprint with `jira sprint add` - feat: Allow to assign epic on create #194 - feat: Cmd to add issues to sprint #205 - feat: Allow to filter by parent #197 - feat: Add order-by filter #206 - feat: Add type on project listing #190 - fix: Make epic add work in next-gen project #195 - fix: Epic creation for next-gen project #192 - fix: Make epic remove work in next-gen project #196 - fix: Make epic list work for next-gen project #201 - fix: Segmentation fault on view #202 - fix(tui): Link/key copy is broken for altered key col #204 - cfg!: Expand config to include project type #191 - cfg!: Rename field to name and add link field to epic #193 - dep: Upgrade rivo/tview #176 - dep: Upgrade outdated deps to latest #177 - dep: Use Go 1.17 #178 **Full Changelog**: ankitpokhrel/jira-cli@v0.1.1...v0.2.0

Treer added 13 commits August 25, 2016 23:38

switching to Bootstrap/php UI

640db7a

Converted first page to Bootstrap

30db6af

Converted most of the second screen

fa4a83d

Finished conversion of settings to php pages

7fe021f

Support platforms without default powerd support, e.g. APU & ALIX

f2044f2

See https://redmine.pfsense.org/issues/5739

Add two extra screens: Interfaces listed by volume, and Interfaces li…

c299aaf

…sted by current traffic

Omitted a part of commit 2d17893

89e4cac

Fixes bug where bps measurements stayed 0

Add Traffic Graph screen

91cd2b6

Shows the same data as the list on the Traffic Graph screen - bandwidth by IP/host

Add refreshed indicator to "bandwidth by ip" screen

0aef722

Bump version to 0.10.1

6c1c4a9

Fix up some of the file heading comments

Cleanup ready for pull request to pfSense

1e435e9

Make label describe data

93f8cfa

The label can go back to "Total today" once resetting the totals daily has been implemented.

netgate-git-updates added the CLA label Aug 25, 2016

Treer added 4 commits August 28, 2016 19:34

Implement "total today" screen.

900b066

The screen was showing totals since boot, so they are now seperate screens. Removed text describing the interface sort order, since this will be fixed if all interfaces can fit on screen.

Prevent "Unknown screen id" errors appearing in the system log

e5c588b

Bump version to 0.10.2

02a47dd

minor cleanup

ce3b115

Treer added 2 commits September 20, 2016 21:21

Update CARP to work with uniqid changes in revision 2a5960b0

a6da89f

https://redmine.pfsense.org/projects/pfsense/repository/revisions/2a5960b07bb2a40aeaf81423b0c52d5629e87e49 (Credit to hubba: https://forum.pfsense.org/index.php?topic=110177.msg652986#msg652986)

Bump version to 0.10.3

735dac6

rbgarga requested changes Dec 5, 2016

View reviewed changes

rbgarga added the Changes requested label Dec 5, 2016

rbgarga self-assigned this Dec 5, 2016

rbgarga requested changes Dec 5, 2016

View reviewed changes

Treer added 3 commits December 10, 2016 16:16

Fix package files.

77c82d9

First part of changes requested by rbgarga

Move license from ESF to APACHE20

b10ce7c

Second part of changes requested by rbgarga

Move license from ESF to APACHE20

ad76a83

Fix driver label

2d29d6a

rbgarga added Pending review/testing and removed Changes requested labels Dec 12, 2016

rbgarga approved these changes Dec 14, 2016

View reviewed changes

netgate-git-updates merged commit 2d29d6a into pfsense:devel Dec 14, 2016

netgate-git-updates pushed a commit that referenced this pull request Dec 14, 2016

Merge pull request #178 from Treer/lcdproc

639f22b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add LCDproc #178

Add LCDproc #178

Treer commented Aug 25, 2016 •

edited

Treer commented Sep 8, 2016 •

edited

rbgarga Dec 5, 2016

rbgarga Dec 5, 2016

rbgarga Dec 5, 2016

rbgarga Dec 5, 2016

rbgarga Dec 5, 2016

rbgarga Dec 5, 2016

rbgarga Dec 5, 2016

rbgarga Dec 5, 2016

Treer commented Dec 10, 2016 •

edited

rbgarga commented Dec 14, 2016

Treer commented Jan 26, 2017

Add LCDproc #178

Add LCDproc #178

Conversation

Treer commented Aug 25, 2016 • edited

Treer commented Sep 8, 2016 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Treer commented Dec 10, 2016 • edited

rbgarga commented Dec 14, 2016

Treer commented Jan 26, 2017

Treer commented Aug 25, 2016 •

edited

Treer commented Sep 8, 2016 •

edited

Treer commented Dec 10, 2016 •

edited