dhcp6c no release option and extra logging #230
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a no release '-n' option to dhcp6c. This is to prevent some ISP's will release the allocated PD or address on receipt of the release signal and issue a new address on next request. As dhcp6c by default sends the release on exit the only way to stop it is by stopping all release signals being sent. the -n option does that. Also added is some extra info logging which is minimul and useful without resorting to the debug log.
|
@marjohn56 ops, you committed files/ directory at repository root directory instead of net/dhcp6. Can you please re-submit? |
|
Bugger ;-)
From: Renato Botelho [mailto:notifications@github.com]
Sent: 15 December 2016 18:52
To: pfsense/FreeBSD-ports <FreeBSD-ports@noreply.github.com>
Cc: marjohn56 <martin@queens-park.com>; Mention <mention@noreply.github.com>
Subject: Re: [pfsense/FreeBSD-ports] dhcp6c no release option and extra logging (#230)
@marjohn56 <https://github.com/marjohn56> ops, you committed files/ directory at repository root directory instead of net/dhcp6. Can you please re-submit?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#230 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/ARIXpuOTOVM3tRoGJEqZg8LMmxJc5Zbnks5rIYxmgaJpZM4LOZuL> . <https://github.com/notifications/beacon/ARIXptYP907PeSQg1Nm37T3KWMnj0Z9Cks5rIYxmgaJpZM4LOZuL.gif>
|
Add -n no release option to prevent dhcpc6 from sending release signal to ISP. Some ISP's will release the allocated address or PD on receipt of the signal and issue new ones on the next request. As this is the default behavior of dhcp6c the only option is to stop it from sending release signals completely, this option handles that used in conjunction with an option in WAN DHCP6 configuration. Also added is some light extra INFO logging that helps to show what dhcp6c is doing.
|
files/ are still there @marjohn56 |
|
Hopefully they have now gone and I've done a new PR, somedays I hate GItHub. Now at #231 |
|
Hi Renato,
I’ll cancel the PR’s for the *.incs and *.php in the morning and and clean it all up as you have requested and issue a new one. I’ve issued a new on for the dhcp6c change, hopefully in the right place this time.
Regards,
Martin
From: Renato Botelho [mailto:notifications@github.com]
Sent: 15 December 2016 18:52
To: pfsense/FreeBSD-ports <FreeBSD-ports@noreply.github.com>
Cc: marjohn56 <martin@queens-park.com>; Mention <mention@noreply.github.com>
Subject: Re: [pfsense/FreeBSD-ports] dhcp6c no release option and extra logging (#230)
@marjohn56 <https://github.com/marjohn56> ops, you committed files/ directory at repository root directory instead of net/dhcp6. Can you please re-submit?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#230 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/ARIXpuOTOVM3tRoGJEqZg8LMmxJc5Zbnks5rIYxmgaJpZM4LOZuL> . <https://github.com/notifications/beacon/ARIXptYP907PeSQg1Nm37T3KWMnj0Z9Cks5rIYxmgaJpZM4LOZuL.gif>
|
netgate-git-updates
pushed a commit
that referenced
this pull request
Mar 16, 2020
Changelog [1]: New APIs * QWebSetting::ErrorPageEnabled - true by default, allows to disable built-in error pages if they are not desirable Improvements * CSS Compositing is now supported * Push is enabled by default for HTTP/2 requests * QtWebKit does not require Python 2 anymore for building and can use Python 3 instead * QtWebKit won't be eager to pick bitmap fonts as a suitable choice for standard font families * More appropriiate hinting option for web fonts is used Bug fixes * Fix memory leak in CustomEvent * SVG fragment identifier is not respected if it is a part of an HTTP URL (#818) * Context menu actions for images in Resources tab of inspector use blob: instead of original URL (#899) * Always enable JavaScript for QWebInspector (#566) * Inspector UI: Only selected item is painted in Styles combobox (#262) * Inspector should inspect itself in DEVELOPER_MODE only (#444) * fast/gradients/css3-color-stop-invalid.html - box is green instead of white (#230) * Work around QTBUG-77308 when using Qt < 5.14 * Fix compilation errors with ICU 65.1 and Qt 5.14 * Fix compilation when QPdf is disabled in Qt * Fix compilation with MinGW for x86_64 target [1] https://github.com/qtwebkit/qtwebkit/releases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No Release and extra minimal debugging.