Squid - fix c-icap/squidclamav/clamav config files handling, fix Unrestricted IPs throttling, improve descriptions, nuke unused code #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
doktornotor
commented
Jan 7, 2017
•
doktornotor
commented
- All required sample files are now shipped with c-icap and squidclamav, use them.
- Always use the distributed sample files to create pfSense customized defaults, in order to prevent the defaults getting out of sync with upstream (such as https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=208374)
- Fix Google Safe Browsing definitions handling (account for safebrowsing.cld as well)
- Fix 'Unrestricted IPs' throttling to work as originally intended (and add a toggle for this to Traffic Mgmt tab - Feature #4752)
added 3 commits
January 7, 2017 11:31
- All required sample files are now shipped with c-icap and squidclamav, use them. - Always use the distributed sample files to create pfSense customized defaults, in order to prevent the defaults getting out of sync with upstream (such as https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=208374)
Need to account for safebrowsing.cld in addition to safebrowsing.cvd
added 6 commits
January 7, 2017 15:12
These have just never existed in settings, AFAICT.
- Fix the original check so that it actually applies to the 'Unrestricted IPs' configured on the ACLs tab. - Throttle even 'Unrestricted IPs' if 'Throttle Unrestricted IPs' is configured on the Traffic Mgmt tab.
doktornotor
changed the title
|
@doktornotor please rebase your fork |
jim-p
approved these changes
Jan 9, 2017
|
@rbgarga - The Makefile conflict should be resolved now. |
rbgarga
approved these changes
Jan 10, 2017
netgate-git-updates
pushed a commit
that referenced
this pull request
Jan 10, 2017
netgate-git-updates
pushed a commit
that referenced
this pull request
Sep 26, 2022
ChangeLog:
[FreeBSD] configure: suggest variable to set if FreeBSD
sys not
found
submitted by @emaste
Updated 00FAQ with lookup to open files via mountpoint
Provided by Jacob Chapman in #240
[FreeBSD] modernize API usage and remove legacy FreeBSD
releases
Contributor DamjanJovanovic (#184) Ed Maste (#250, #251,
Warner Losh (#253)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.