Redmine #7548 Add absolute offset to NTP stats #354
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The fix and other changes should be separate commits and/or PR. |
|
All those left/right/adjusts variables were just counting up an array index. $ds_key_out does the job now with 1 variable that gets incremented at the appropriate places. |
|
See #355 for a version with the code refactored first before adding the feature. After refactoring the crud first, it looks much cleaner to add the feature. |
|
Thank you Phil. The separate commits makes it much easier to follow and see what each what does. Really appreciate it. Thank you. |
|
Once I started on the separate commits, I thought "what the heck" and went all the with the refactoring. So the other PR has a lot (more,better) refactored code than here. |
netgate-git-updates
pushed a commit
that referenced
this pull request
Mar 31, 2020
FreeBSD-relevant ChangeLog extract since 3.0.6: * Remove RANDFILE environment variable (#261) * Workaround for bug in win32 mktemp (#247, #305, PR #312) * Handle IP address in SAN and renewals (#317) * Workaround for ash and no set -o echo (#319) * Shore up windows testing framework (#314) * Provide upgrade mechanism for older versions of EasyRSA (#349) * Add support for KDC certificates (#322) * Add support for Edward Curves (#354, #350) * Add support for EASYRSA_PASSIN and EASYRSA_PASSOUT env vars (#368) * Add support for RID to SAN (#362) Update WWW: link in pkg-descr. Remove patches that have been integrated upstream. Shuffle USES=-line to please portlint. Add NO_ARCH=yes, since this is all scripts and text. Reported by: Eric F Crist (upstream maintainer)
netgate-git-updates
pushed a commit
that referenced
this pull request
May 15, 2020
Recent changes since MooseFS 3.0.112: * MooseFS 3.0.113-1 (2020-05-04) - (master) removed unnecessary debug syslog messages - (check) increased usleep tolerance due to some operating systems (issue #351) - (master) changed condition that decides if master should wait for more chunks during I/O - (mount) delayed setting channel for fuse notifications (very rare segfault in libfuse2 during init) - (client+master) changed conditions for ancestor test in getattr (issue #350) - (cs) added parameter for number of chunks to be send in single register packet - (cs) fixed reporting damaged chunks in testing function (issue #352) - (cs) removed some unnecessary damaged chunk notifications - (client) changed open test in setattr (related to issue #350) - (master) fixed handling truncate for open files (related to issue #350) - (master) added uid mapping in setfacl function - (master+client) added support for atomic truncate with open - (master+client) fixed keep cache conditions - (cs) introduced official label format defined in chunkserver configuration - (nbd) added readonly mode and locking - (cs) fixed condition in choosing disks for internal rebalance - (mount) added workaround in access for a bug in FreeBSD kernel (issue #354) - (cs) fixed master reconnection conditions (reload usually shouldn't cause reconnection) - (freebsd) fixed FreeBSD port (makeports.sh) - (master) changed disk removal detection algorithm (issue #356) - (cs) fixed calculating size limits - (cs) added handling inode limits in local filesystems on chunkservers (issue #358) - (master) added topology grouping when new chunks are about to be created (prefer closer servers) - (master) added more error messages to bgsaver - (cs) added changing subfolder during internal rebalance (related to issue #326) - (master+cs) added optional logging of long function execution times - (all) fixes of small errors found by static code analysers - (mount) turn off dentry invalidator for Linux kernels >= 4.19 (related to issue #357) - (master) changed condition that checks timestamp in changelogs (less prone to small clock differences) - (daemons) added time refresh function (for future use) - (cgi+cli) changed mark for removal state name UNKNOWN->PENDING (related to issue #359) - (client) decreased max IDLE time in writer module from 1s to 0.1s - (client) update inode in dentry invalidator - (tools) fixed mfscopyeattr, mfsseteattr and mfs*arch tools - (master+client) added support for new eattrs: immutable, appendonly, undeletable (setting new undeletable extra attribute appropriately can help with issues like #357) - (client) silenced "kern.proc.filedesc" syslog messages on FreeBSD (issue #360) PR: 246416 Submitted by: MooseFS FreeBSD Team <freebsd@moosefs.pro> (maintainer)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plot and list the absolute value of the NTP time offset, as well as the existing plus/minus value.
See Redmine https://redmine.pfsense.org/issues/7548
Forum https://forum.pfsense.org/index.php?topic=130468.0
for details.
In order to do add this, it was easier to also refactor the way the index of the output array was kept track of. Seems to be simpler to understand now. This whole code could do with refactoring - I added more duplicated code to what was already there. But I am not starting down that path right now.