Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced the version of my Norwegian/Nordic list #713

Merged
merged 3 commits into from
Nov 26, 2019

Conversation

DandelionSprout
Copy link
Contributor

@DandelionSprout DandelionSprout commented Nov 23, 2019

I was made aware through DandelionSprout/adfilt#52 that pfBlockerNG still used my increasingly uBlock Origin-targeted main version of my Nordic list, which is said to have completely broke the list in pfBlockerNG after I recently removed the [Adblock Plus 3.4] tag from that particular list version.

I have therefore replaced that file link with that of the hosts version of my list, and am hoping that this issue is considered critical enough that it'll be fixed relatively soon.

@rbgarga
Copy link
Member

rbgarga commented Nov 25, 2019

@BBcan177 can you take a look at it please?

@BBcan177
Copy link
Contributor

Approved

Copy link
Member

@rbgarga rbgarga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DandelionSprout please bump PORTVERSION or PORTREVISION on port Makefile to make sure we get a new package

@DandelionSprout
Copy link
Contributor Author

I've of course kept the "Allow edits from maintainers" setting turned on all along, so you guys can make whichever edits to my changes/branch that you want to.

Especially as I perform all my changes directly on GitHub through a web browser, and therefore have zero idea how to do what you just told me to do or where.

@DandelionSprout
Copy link
Contributor Author

Nevermind my previous comment, it seems. I studied #712 to figure out which Makefile file I had to edit, so I think I've made an attempt at that just now.

@netgate-git-updates netgate-git-updates merged commit a25faff into pfsense:devel Nov 26, 2019
netgate-git-updates pushed a commit that referenced this pull request Nov 27, 2021
Changelog:
	* Fixed: Version `Qt_5.15' not found (required by
	  /usr/bin/ksnip). (#712)
	* Fixed: CI packages show continuous suffix for tagged build.
	  (#710)
	* Fixed: kImageAnnotator not translated with deb package. (#359)
	* Fixed: Windows packages increased in size. (#713)
	* Fixed: The string 'Actions' is not available for translation.
	  (#729)
	* Fixed: HiDPI issue with multiple screen on Windows. (#668)
	* Fixed: Snipping Area not closing when pressing ESC. (#735)
	* Fixed: Sometimes "Snipping Area Rulers" not shown after
	  starting rectangular selection. (#684)
	* Fixed: Cursor not positioned correctly when snipping area
	  opens. (#736)
	* Fixed: Mouse cursor not captured when triggered via global
	  shortcut. (#737)
	* Fixed: Dual 4K screens get scrambled on X11. (#734)
	* Fixed: VCRUNTIME140_1.dll was not found. (#743)
	* Fixed: Screenshot area issue when monitor count changes on
	  Windows. (#722)
	* Fixed: Wayland does not support QWindow::requestActivate().
	  (#656)
	* Fixed: Wrong area is captured on a Wayland screen scaling.
	  (#691)
	* Changed: Enforce xdg-desktop-portal screenshots for Gnome >=
	  41. (#727)
	* Fixed kImageAnnotator: Crash while typing text on wayland.
	  (#256)
	* Changed kImageAnnotator: Show scrollbar when not all tools
	  visible. (#258)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants