nrpe: allow ipv6 nagios servers addresses #722
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jim-p
requested changes
Dec 18, 2019
| @@ -247,7 +247,7 @@ function nrpe_custom_php_validation_command($post, &$input_errors) { | |||
| } | |||
| } | |||
| foreach (explode(",", $post['allowed_hosts']) as $host) { | |||
| if (!empty($host) && !is_ipaddr($host)) { | |||
| if (!empty($host) && !is_ipaddr($host) && !is_ipaddrv6($host)) { | |||
There was a problem hiding this comment.
is_ipaddr() matches both IPv4 and IPv6, so this change would not alter any behavior.
pfSense shell: $host = '10.0.0.1';
pfSense shell: var_dump( (!empty($host) && !is_ipaddr($host)) );
pfSense shell: exec
bool(false)
pfSense shell: var_dump( (!empty($host) && !is_ipaddr($host) && !is_ipaddrv6($host)) );
pfSense shell: exec
bool(false)
pfSense shell: $host = '2001:db8::1';
pfSense shell: var_dump( (!empty($host) && !is_ipaddr($host)) );
pfSense shell: exec
bool(false)
pfSense shell: var_dump( (!empty($host) && !is_ipaddr($host) && !is_ipaddrv6($host)) );
pfSense shell: exec
bool(false)
There was a problem hiding this comment.
in this case we don't need this PR at all
netgate-git-updates
pushed a commit
that referenced
this pull request
Nov 27, 2021
Changelog: * Fixed: Version `Qt_5.15' not found (required by /usr/bin/ksnip). (#712) * Fixed: CI packages show continuous suffix for tagged build. (#710) * Fixed: kImageAnnotator not translated with deb package. (#359) * Fixed: Windows packages increased in size. (#713) * Fixed: The string 'Actions' is not available for translation. (#729) * Fixed: HiDPI issue with multiple screen on Windows. (#668) * Fixed: Snipping Area not closing when pressing ESC. (#735) * Fixed: Sometimes "Snipping Area Rulers" not shown after starting rectangular selection. (#684) * Fixed: Cursor not positioned correctly when snipping area opens. (#736) * Fixed: Mouse cursor not captured when triggered via global shortcut. (#737) * Fixed: Dual 4K screens get scrambled on X11. (#734) * Fixed: VCRUNTIME140_1.dll was not found. (#743) * Fixed: Screenshot area issue when monitor count changes on Windows. (#722) * Fixed: Wayland does not support QWindow::requestActivate(). (#656) * Fixed: Wrong area is captured on a Wayland screen scaling. (#691) * Changed: Enforce xdg-desktop-portal screenshots for Gnome >= 41. (#727) * Fixed kImageAnnotator: Crash while typing text on wayland. (#256) * Changed kImageAnnotator: Show scrollbar when not all tools visible. (#258)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redmine Issue: https://redmine.pfsense.org/issues/9973
Ready for review
Nagios NRPE package lacks IPv6 capabilities.