Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FRR Add support for OSPFv3 areas #955

Merged
merged 2 commits into from
Oct 6, 2020
Merged

FRR Add support for OSPFv3 areas #955

merged 2 commits into from
Oct 6, 2020

Conversation

bmhughes
Copy link
Contributor

@bmhughes bmhughes commented Oct 4, 2020

Contrary to the FRR documentation (http://docs.frrouting.org/en/latest/ospf6d.html#ospf6-area)
OSPFv3 areas are fully supported in FRR (FRRouting/frr#2453)

  • Add area tab to OSPFv3 configuration.
  • Split OSPFv3 configuration generation out into Area/Interface/Main functions as OSPFv2.
  • Update validation for OSPFv3 to support multiple areas.

Continuation of Redmine issue: https://redmine.pfsense.org/issues/10789

@bmhughes
Fix typo in frr_bgp.xml
6eb86d9
@bmhughes
Add support for OSPFv3 areas
ae1d920 
Contrary to the FRR documentation (http://docs.frrouting.org/en/latest/ospf6d.html#ospf6-area)
OSPFv3 areas are fully supported in FRR (FRRouting/frr#2453)

- Add area tab to OSPFv3 configuration.
- Split OSPFv3 configuration generation out into Area/Interface/Main functions as OSPFv2.
- Update validation for OSPFv3 to support multiple areas.
jim-p
jim-p approved these changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@jim-p jim-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as it's working now, it should be OK. Last time I tried it in FRR directly it failed in various ways but that was a couple FRR versions ago (Around 4.x or 5.x I think).

@bmhughes
Copy link
Contributor Author

bmhughes commented Oct 5, 2020

As long as it's working now, it should be OK. Last time I tried it in FRR directly it failed in various ways but that was a couple FRR versions ago (Around 4.x or 5.x I think).

I've quickly tested it with a few VMs and it seemed ok without pushing it, VyOS has support as well so i'm presuming it works as designed at this point.

@netgate-git-updates netgate-git-updates merged commit e1427fa into pfsense:devel Oct 6, 2020
@vktg vktg mentioned this pull request Oct 8, 2020
Merged
2 tasks
@bmhughes bmhughes deleted the frr-enable-ospfv3-areas branch October 8, 2020 11:15
netgate-git-updates pushed a commit that referenced this pull request Nov 13, 2023
@Jakker @fernape
dns/unbound: Update to 1.19.0
bb5a92c 
ChangeLog: https://nlnetlabs.nl/news/2023/Nov/08/unbound-1.19.0-released/

Features
* Fix #850: [FR] Ability to use specific database in Redis, with new
  redis-logical-db configuration option.
* Merge #944: Disable EDNS DO.  Disable the EDNS DO flag in upstream requests.
  This can be helpful for devices that cannot handle DNSSEC information. But it
  should not be enabled otherwise, because that would stop DNSSEC validation.
  The DNSSEC validation would not work for Unbound itself, and also not for
  downstream users. Default is no. The option is disable-edns-do: no
* Expose the script filename in the Python module environment 'mod_env' instead
  of the config_file structure which includes the linked list of scripts in a
  multi Python module setup; fixes #79.
* Expose the configured listening and outgoing interfaces, if any, as a list of
  strings in the Python 'config_file' class instead of the current Swig object
  proxy; fixes #79.
* Mailing list patches from Daniel Gröber for DNS64 fallback to plain AAAA when
  no A record exists for synthesis, and minor DNS64 code refactoring for better
  readability.
* Merge #951: Cachedb no store. The cachedb-no-store: yes option is used to stop
  cachedb from writing messages to the backend storage.  It reads messages when
  data is available from the backend. The default is no.

Bug Fixes
* Fix for version generation race condition that ignored changes.
* Fix #942: 1.18.0 libunbound DNS regression when built without
   OpenSSL.
* Fix for WKS call to getservbyname that creates allocation on exit in unit test
  by testing numbers first and testing from the services list later.
* Fix autoconf 2.69 warnings in configure.
* Fix #927: unbound 1.18.0 make test error. Fix make test without SHA1.
* Merge #931: Prevent warnings from -Wmissing-prototypes.
* Fix to scrub resource records of type A and AAAA that have an
   inappropriate size. They are removed from responses.
* Fix to move msgparse_rrset_remove_rr code to util/msgparse.c.
* Fix to add EDE text when RRs have been removed due to length.
* Fix to set ede match in unit test for rr length removal.
* Fix to print EDE text in readable form in output logs.
* Fix send of udp retries when ENOBUFS is returned. It stops looping
   and also waits for the condition to go away. Reported by Florian
   Obser.
* Fix authority zone answers for obscured DNAMEs and delegations.
* Merge #936: Check for c99 with autoconf versions prior to 2.70.
* Fix to remove two c99 notations.
* Fix rpz tcp-only action with rpz triggers nsdname and nsip.
* Fix misplaced comment.
* Merge #881: Generalise the proxy protocol code.
* Fix #946: Forwarder returns servfail on upstream response noerror no
   data.
* Fix edns subnet so that queries with a source prefix of zero cause
   the recursor send no edns subnet option to the upstream.
* Fix that printout of EDNS options shows the EDNS cookie option by
   name.
* Fix infinite loop when reading multiple lines of input on a broken
   remote control socket. Addesses #947 and #948.
* Fix #949: "could not create control compt".
* Fix that cachedb does not warn when serve-expired is disabled about
   use of serve-expired-reply-ttl and serve-expired-client-timeout.
* Fix for #949: Fix pythonmod/ubmodule-tst.py for Python 3.x.
* Better fix for infinite loop when reading multiple lines of input on
   a broken remote control socket, by treating a zero byte line the
   same as transmission end. Addesses #947 and #948.
* For multi Python module setups, clean previously parsed module
   functions in __main__'s dictionary, if any, so that only current
   module functions are registered.
* Fix #954: Inconsistent RPZ handling for A record returned along with
   CNAME.
* Fixes for the DNS64 patches.
* Update the dns64_lookup.rpl test for the DNS64 fallback patch.
* Merge #955 from buevsan: fix ipset wrong behavior.
* Update testdata/ipset.tdir test for ipset fix.
* Fix to print detailed errors when an SSL IO routine fails via
   SSL_get_error.
* Clearer configure text for missing protobuf-c development libraries.
* autoconf.
* Merge #930 from Stuart Henderson: add void to
   log_ident_revert_to_default declaration.
* Fix #941: dnscrypt doesn't work after upgrade to 1.18 with
   suggestion by dukeartem to also fix the udp_ancil with dnscrypt.
* Fix SSL compile failure for definition in log_crypto_err_io_code_arg.
* Fix SSL compile failure for other missing definitions in
   log_crypto_err_io_code_arg.
* Fix compilation without openssl, remove unused function warning.
* Mention flex and bison in README.md when building from repository
   source.

PR:		275012
Reported by:	jaap@NLnetLabs.nl (maintainer)
netgate-git-updates pushed a commit that referenced this pull request Mar 4, 2024
@Jakker
dns/unbound: Update to 1.19.0
21b70e4 
ChangeLog: https://nlnetlabs.nl/news/2023/Nov/08/unbound-1.19.0-released/

Features
* Fix #850: [FR] Ability to use specific database in Redis, with new
  redis-logical-db configuration option.
* Merge #944: Disable EDNS DO.  Disable the EDNS DO flag in upstream requests.
  This can be helpful for devices that cannot handle DNSSEC information. But it
  should not be enabled otherwise, because that would stop DNSSEC validation.
  The DNSSEC validation would not work for Unbound itself, and also not for
  downstream users. Default is no. The option is disable-edns-do: no
* Expose the script filename in the Python module environment 'mod_env' instead
  of the config_file structure which includes the linked list of scripts in a
  multi Python module setup; fixes #79.
* Expose the configured listening and outgoing interfaces, if any, as a list of
  strings in the Python 'config_file' class instead of the current Swig object
  proxy; fixes #79.
* Mailing list patches from Daniel Gröber for DNS64 fallback to plain AAAA when
  no A record exists for synthesis, and minor DNS64 code refactoring for better
  readability.
* Merge #951: Cachedb no store. The cachedb-no-store: yes option is used to stop
  cachedb from writing messages to the backend storage.  It reads messages when
  data is available from the backend. The default is no.

Bug Fixes
* Fix for version generation race condition that ignored changes.
* Fix #942: 1.18.0 libunbound DNS regression when built without
   OpenSSL.
* Fix for WKS call to getservbyname that creates allocation on exit in unit test
  by testing numbers first and testing from the services list later.
* Fix autoconf 2.69 warnings in configure.
* Fix #927: unbound 1.18.0 make test error. Fix make test without SHA1.
* Merge #931: Prevent warnings from -Wmissing-prototypes.
* Fix to scrub resource records of type A and AAAA that have an
   inappropriate size. They are removed from responses.
* Fix to move msgparse_rrset_remove_rr code to util/msgparse.c.
* Fix to add EDE text when RRs have been removed due to length.
* Fix to set ede match in unit test for rr length removal.
* Fix to print EDE text in readable form in output logs.
* Fix send of udp retries when ENOBUFS is returned. It stops looping
   and also waits for the condition to go away. Reported by Florian
   Obser.
* Fix authority zone answers for obscured DNAMEs and delegations.
* Merge #936: Check for c99 with autoconf versions prior to 2.70.
* Fix to remove two c99 notations.
* Fix rpz tcp-only action with rpz triggers nsdname and nsip.
* Fix misplaced comment.
* Merge #881: Generalise the proxy protocol code.
* Fix #946: Forwarder returns servfail on upstream response noerror no
   data.
* Fix edns subnet so that queries with a source prefix of zero cause
   the recursor send no edns subnet option to the upstream.
* Fix that printout of EDNS options shows the EDNS cookie option by
   name.
* Fix infinite loop when reading multiple lines of input on a broken
   remote control socket. Addesses #947 and #948.
* Fix #949: "could not create control compt".
* Fix that cachedb does not warn when serve-expired is disabled about
   use of serve-expired-reply-ttl and serve-expired-client-timeout.
* Fix for #949: Fix pythonmod/ubmodule-tst.py for Python 3.x.
* Better fix for infinite loop when reading multiple lines of input on
   a broken remote control socket, by treating a zero byte line the
   same as transmission end. Addesses #947 and #948.
* For multi Python module setups, clean previously parsed module
   functions in __main__'s dictionary, if any, so that only current
   module functions are registered.
* Fix #954: Inconsistent RPZ handling for A record returned along with
   CNAME.
* Fixes for the DNS64 patches.
* Update the dns64_lookup.rpl test for the DNS64 fallback patch.
* Merge #955 from buevsan: fix ipset wrong behavior.
* Update testdata/ipset.tdir test for ipset fix.
* Fix to print detailed errors when an SSL IO routine fails via
   SSL_get_error.
* Clearer configure text for missing protobuf-c development libraries.
* autoconf.
* Merge #930 from Stuart Henderson: add void to
   log_ident_revert_to_default declaration.
* Fix #941: dnscrypt doesn't work after upgrade to 1.18 with
   suggestion by dukeartem to also fix the udp_ancil with dnscrypt.
* Fix SSL compile failure for definition in log_crypto_err_io_code_arg.
* Fix SSL compile failure for other missing definitions in
   log_crypto_err_io_code_arg.
* Fix compilation without openssl, remove unused function warning.
* Mention flex and bison in README.md when building from repository
   source.

PR:		275012
Reported by:	jaap@NLnetLabs.nl (maintainer)

(cherry picked from commit bb5a92c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jim-p jim-p jim-p approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@bmhughes @jim-p @netgate-git-updates