This repository has been archived by the owner on Jan 22, 2018. It is now read-only.
Redmine #5727 TFTP protect against empty stuff #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) If the user presses Save when there was no interface selected, and the user has still not selected an interface, then do not attempt to unset() tftpdinterface in the config when it is already unset. 2) If the user does backup/restore or other similar stuff when the tftpboot directory has no files in it, then do not do chmod of the (non-existent) files. This avoids a "No such file or directory" message being logged.
|
I don't see where the TFTP package has been converted yet for 2.3 - so there is no code to patch for that. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the user has still not selected an interface, then do not attempt to
unset() tftpdinterface in the config when it is already unset.
tftpboot directory has no files in it, then do not do chmod of the
(non-existent) files. This avoids a "No such file or directory" message
being logged.
This is for 2.1.* and 2.2.* - I will also make an equivalent PR in the other repo for 2.3