Add enable link to Status > UPnP & NAT-PMP error message if disabled (Todo #6689) #3290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@doktornotor please do not update .pot file manually. When it's required, just add a note on PR and I can run script to re-generate it after merge |
|
Oh, you have a script now? Great to know, I'd rather never touch the giant blob again, it's a big pain. |
|
@doktornotor yes, it's on ./tools/scripts/update_pot.sh :) |
|
@rbgarga - Grrrh... should have known earlier. Definitely will avoid touching the pot thing in future, thanks for the pointer. |
rbgarga
requested changes
Dec 20, 2016
| @@ -52,7 +52,7 @@ | |||
| !$config['installedpackages']['miniupnpd']['config'][0]['iface_array'] || | |||
| !$config['installedpackages']['miniupnpd']['config'][0]['enable']) { | |||
|
|
|||
| print_info_box('UPnP is currently disabled.', 'danger'); | |||
| print_info_box(gettext('UPnP is currently disabled. Go to <a href="pkg_edit.php?xml=miniupnpd.xml">Services > UPnP & NAT-PMP</a> to enable.'), 'danger'); | |||
There was a problem hiding this comment.
Please remove html content from gettext() string and use sprintf
added 2 commits
December 20, 2016 22:57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.