Fix #7316 Alias Edit keep pattern, placeholder, title in sync #3583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbgarga
approved these changes
Mar 2, 2017
|
@sbeaver-netgate @rbgarga @jim-p another little fix that is labeled tested and could easily be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some new rows to what is already displayed, then change the alias type between a host and port type. The pattern for the extra rows is not changed. That is because $counter is a fixed number generated when the page is built with PHP - so the JS only manipulates the first $counter rows initially displayed.
The .each() code fixes this. Note that the special matching is needed, because there are other elements that start with 'address' - e.g. 'address_subnet'
Make the title attribute ("hover text") and placeholder attribute also change their text value as the alias type is changed. This is the problem reported in the Redmine issue.