-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tlsauth keydir options to openvpn client and server #3999
Conversation
To effectively track changes and bug/feature requests, we require an entry on the pfSense Redmine issue tracker associated with every pull request, and likewise the Redmine entry should also have a link back to the pull request. Please associate this PR to a Redmine issue either by locating an existing issue at https://redmine.pfsense.org or by creating a new issue. Add a link to the Redmine issue that points to this PR, and also add a link on the PR to the Redmine issue. For more information, see https://www.netgate.com/docs/pfsense/development/submitting-a-pull-request-via-github.html Thanks! |
Hi, sorry I do not understand why the status here is still Changed Requested, being them here: f08369e |
@jim-p hi, there is any plan to include this in the code? thanks |
break; | ||
case '': | ||
case '0': | ||
default: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you are using default:
here you don't need to explicit add case '':
and case '0':
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in f93ec38
break; | ||
case '': | ||
case '1': | ||
default: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you are using default: here you don't need to explicit add case '': and case '1':
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in f93ec38
This patch series implements Ticket: #9030