Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tlsauth keydir options to openvpn client and server #3999

Merged
merged 5 commits into from
Sep 12, 2019

Conversation

vpiserchia
Copy link
Contributor

@vpiserchia vpiserchia commented Oct 9, 2018

This patch series implements Ticket: #9030

src/etc/inc/openvpn.inc Outdated Show resolved Hide resolved
@jim-p
Copy link
Contributor

jim-p commented Oct 9, 2018

To effectively track changes and bug/feature requests, we require an entry on the pfSense Redmine issue tracker associated with every pull request, and likewise the Redmine entry should also have a link back to the pull request.

Please associate this PR to a Redmine issue either by locating an existing issue at https://redmine.pfsense.org or by creating a new issue. Add a link to the Redmine issue that points to this PR, and also add a link on the PR to the Redmine issue.

For more information, see https://www.netgate.com/docs/pfsense/development/submitting-a-pull-request-via-github.html

Thanks!

@vpiserchia
Copy link
Contributor Author

Hi, sorry I do not understand why the status here is still Changed Requested, being them here: f08369e
regards

@vpiserchia
Copy link
Contributor Author

vpiserchia commented Dec 14, 2018

@jim-p hi, there is any plan to include this in the code? thanks

break;
case '':
case '0':
default:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you are using default: here you don't need to explicit add case '': and case '0':

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in f93ec38

break;
case '':
case '1':
default:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you are using default: here you don't need to explicit add case '': and case '1':

Copy link
Contributor Author

@vpiserchia vpiserchia Jun 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in f93ec38

@netgate-git-updates netgate-git-updates merged commit 23dfe5a into pfsense:master Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants