DynDNS: add deSEC IPv4&v6 simultaneos update #4543
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `_checkIP()` method is only obtaining either the legacyIP as default or the IP if the flag is set for it. For services that would override one entry with the newest on each update it would not be possible to create entries with both, as this requires them to be sent in the same request. For this purpose this adds a new flag to signal a service needs both, legacyIP and IP, available at the same time and a new field `_dnsLegacyIP`. If the new flag isn't set (which is the default) the `_checkIP()` works like before. If the new flag is set, the `_dnsIP` field will hold the IP and the `_dnsLegacyIP` the legacyIP. To not break the cached-IP handling/having to fool around there as well, the return of the `_checkIP()` is the legacyIP as default and if both formats are needed and only IP if the `_useIPv6` is set.
Leaves the yet included services `deSEC` and `deSEC-v6` untouched. These are using the automatic ip-recognition from the dns service for both record types. This new service to create/update an entry for the same dns name with both record types requires the IPs for both records simultaneously, for which this new service is, leaving the distinct record services in place for people only want to update a dedicated record.
9Lukas5
force-pushed
the
desec-A-and-AAAA-simultaneous-update
branch
from
a47f1c4
to
2a06e39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leaves the yet included services deSEC and deSEC-v6 untouched.
These are using the automatic ip-recognition from the dns service for
both record types.
This new service to create/update an entry for the same dns name with
both record types requires the IPs for both records simultaneously,
for which this new service is, leaving the distinct record services in
place for people only want to update a dedicated record.
Depends on #4542