Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support mitigating BEAST attack, see http://forum.pfsense.org/index.php/topic,63001.0.html #683

Merged
merged 1 commit into from
Jul 14, 2013

Conversation

dhatz
Copy link
Contributor

@dhatz dhatz commented Jul 1, 2013

According to http://redmine.lighttpd.net/projects/lighttpd/wiki/Release-1_4_30

"...by setting
ssl.cipher-list = "ECDHE-RSA-AES256-SHA384:AES256-SHA256:RC4-SHA:RC4:HIGH:!MD5:!aNULL:!EDH:!AESGCM"
you can mitigate BEAST attacks."

See discussion at http://forum.pfsense.org/index.php/topic,63001.0.html

According to http://redmine.lighttpd.net/projects/lighttpd/wiki/Release-1_4_30

"...by setting

ssl.cipher-list = "ECDHE-RSA-AES256-SHA384:AES256-SHA256:RC4-SHA:RC4:HIGH:!MD5:!aNULL:!EDH:!AESGCM"

you can mitigate BEAST attacks."
@jim-p
Copy link
Contributor

jim-p commented Jul 14, 2013

Have you tried applying this commit and ensuring that many browsers/platforms still work correctly? Of most interest would be browsers such as Safari on iOS, the Android browser (pre-Chrome), Opera, etc. If we can get confirmation that it does not negatively impact clients, then such a change is much more likely to be merged in.

@dhatz
Copy link
Contributor Author

dhatz commented Jul 14, 2013

I've only tested it with Chrome, Firefox and MSIE8 on Windows & Linux. However since this is lighttpd's "official" fix to mitigate the risk of BEAST attacks, and it has been published almost 1.5 year ago, and I couldn't find any reports about incompatibilities, I would assume it's reasonably safe to merge.

Btw haven't you heard from any of your commercial support customers about failing a PCI audit due to the BEAST issue ? (because I've found quite a few such posts online)

@jim-p
Copy link
Contributor

jim-p commented Jul 14, 2013

We maybe have seen 1-2 complaints but it wasn't a critical thing at the time since access was very restricted by those customers to get around it. The existing cipher list was crafted because of brokenness in Safari on iOS so I'd at least like to see it tested there before moving forward with the fix.

@jim-p
Copy link
Contributor

jim-p commented Jul 14, 2013

So far it seems OK on:
Chrome 28 on Android 4.1.1
Browser on Android 4.1.1
Browser on Android 2.3.4
Chromium 27 on FreeBSD
Konquerer 4.10.5 on FreeBSD
Opera 12.16 on FreeBSD
Firefox 22 on Windows
Chrome 28 on Windows
IE 10 on Windows 8
Safari on iOS 6.1.3 (iPod Touch)
Chrome 27 on iOS 6.1.3 (iPod Touch)
Safari 6 on OS X 10.8.2
Chrome 28 on OS X 10.8.2

Seems solid from what I can see, that should cover just about every major platform and/or browser. I'll go ahead and merge it.

jim-p added a commit that referenced this pull request Jul 14, 2013
@jim-p jim-p merged commit 3487a5c into pfsense:RELENG_2_1 Jul 14, 2013
@dhatz dhatz deleted the RELENG_2_1 branch July 14, 2013 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants