GSoC 2023: Yige Huang Week 2 #299
Conversation
| @@ -16,13 +16,6 @@ SELECT * FROM pgr_withPointsDD( | |||
| driving_side => 'l', | |||
| equicost => true); | |||
| /* -- q4 */ | |||
| SELECT * FROM pgr_withPointsDD( | |||
There was a problem hiding this comment.
Do not delete the query its been used in the documentation.
Put it back.
| @@ -34,7 +34,7 @@ CREATE FUNCTION _pgr_withPointsDD( | |||
| distance FLOAT, | |||
|
|
|||
| directed BOOLEAN DEFAULT true, | |||
| driving_side CHAR DEFAULT 'b', | |||
| driving_side CHAR DEFAULT 'r', | |||
There was a problem hiding this comment.
I still like the default value to be r, About getting rid of b we need to discuss
| @@ -20,53 +20,17 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. | |||
|
|
|||
| BEGIN; | |||
|
|
|||
| SELECT PLAN(6); | |||
There was a problem hiding this comment.
Please do not change pgtap tests at this time, put it back as it was ...
Of course pgtap will fail, it is expected.
| CREATE FUNCTION pgr_withPointsDD( | ||
| TEXT, --edges_sql (required) | ||
| TEXT, -- points_sql (required) | ||
| ANYARRAY, -- from_vid (required) | ||
| FLOAT, -- distance (required) | ||
|
|
||
| directed BOOLEAN DEFAULT true, | ||
| driving_side CHAR DEFAULT 'b', | ||
| driving_side CHAR DEFAULT 'r', |
There was a problem hiding this comment.
This is a tricky change,
Basically the default for versions 3.5 & under is band the default for 3.6 and after is r
For the moment lest leave it like it is here, but open an issue "reminder of default value" in your fork and put a link to this comment
There was a problem hiding this comment.
issue for reminder: squarege#5
| @@ -54,6 +54,9 @@ void process( | |||
| Path_rt **result_tuples, | |||
| size_t *result_count) { | |||
| driving_side[0] = estimate_drivingSide(driving_side[0]); | |||
| if (driving_side[0] != 'r' && driving_side[0] != 'l') { | |||
There was a problem hiding this comment.
Probably not the best place to check, did you analyze what estimate_drivingSide is doing?
There was a problem hiding this comment.
Yes, I did. estimate_drivingSide converts the input character to lowercase, and returns r, l or b (if it is neither r nor l)
As the estimate_drivingSide function is also used by other withPoints functions, modifying it will have a greater impact,
so I made modifications above with reference to the following code:
GSoC-pgRouting/src/trsp/trsp_withPoints.c
Lines 68 to 71 in 81bcd0c
But if the default for versions 3.6 and after is r, maybe I can change estimate_drivingSide?
Changes proposed in this pull request:
start_vid.driving_side:Value in
[r, l, b]indicating if the driving side is:rfor right driving side.lfor left driving side.bfor both.Value in
[r, R, L, l]indicating if the driving side is:r,Rfor right driving sidel,Lfor left driving sideAny other value (including NULL) will be considered as
r@pgRouting/admins