Modifying withpointsdd #346
Conversation
* [drivers][driving_distance] driver added capability of including new result column * changed structure: Path_rt -> MST_rt * simplified code, removed parameter names * [driving_distance] new file: withPointsDD.hpp * created a new class to calculate depth * used pgrouting::functions namespace
…instead of b as the default value
* Handling old & new code * Removing unnecesary comments * [C++] Calling function to get new results column * [C] Creating internal function _pgr_v4withpointsdd for new signature * [C] Changing the evaluation on the driving side * if graph is directed then valid values are [R, L, r, l], * else valid values are [B, b]
* Changing driving side from optional to compulsory param * Including start_vid and depth in the output of single vertex overload * Including depth in the output of multiple vertices overload * Updating v3.6 signature file
* [pgr_drivingDistance] Adjusting the description of parameter names: * from_v -> start_vid * [pgr_withPointsDD] Updating for new signature and new outputs * [migration] Updating migration guidance for pgr_withPointsDD * [pgRouting-introduction] Adding name into developer list
| @@ -122,7 +122,7 @@ Driving distance optional parameters | |||
| * - ``equicost`` | |||
| - ``BOOLEAN`` | |||
| - ``true`` | |||
| - * When ``true`` the node will only appear in the closest ``from_v`` | |||
| - * When ``true`` the node will only appear in the closest ``start_vid`` | |||
There was a problem hiding this comment.
You can not modify this file, It is not pgr_withPointsDD
| @@ -20,6 +20,11 @@ Results can be different because of the changes. | |||
|
|
|||
| Migrating functions: | |||
|
|
|||
| :doc:`pgr_withPointsDD` signatures have changed, with the addition of new columns | |||
There was a problem hiding this comment.
Please write in alphabetical order
| @@ -38,6 +43,76 @@ Migration of functions that add new columns | |||
| .. contents:: Contents | |||
| :local: | |||
|
|
|||
| Migration of ``pgr_withPointsDD`` | |||
There was a problem hiding this comment.
Please also place this in alphabetical order (So it is the last one)
| @@ -2,7 +2,7 @@ | |||
| /*PGR-GNU***************************************************************** | |||
|
|
|||
| Copyright (c) 2018 pgRouting developers | |||
| Mail: project@pgrouting.org | |||
| Mail: project at pgrouting.org | |||
There was a problem hiding this comment.
This test is failing when executed on an old version.
https://github.com/pgRouting/GSoC-pgRouting/actions/runs/5906112392/job/16021495975#step:9:176
I recommend the following:
Restart from scratch:
CREATE OR REPLACE FUNCTION test_old()
original code
DROP any table that was created
LANGUAGE plpgsql;
CREATE OR REPLACE FUNCTION test_new()
adjust original code to new signature
DROP any table that was created
LANGUAGE plpgsql;
CREATE OR REPLACE FUNCTION do_test()
IF min_version('3.6.0') then
RETURN QUERY ... test_new_code()
ELSE
RETURN QUERY ... test_old_code()
LANGUAGE plpgsql;
Changes proposed in this pull request:
@pgRouting/admins