Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User interface #43

Closed
cvvergara opened this issue Apr 29, 2015 · 8 comments
Closed

User interface #43

cvvergara opened this issue Apr 29, 2015 · 8 comments

Comments

@cvvergara
Copy link
Member

Program parameters, like name of file, database.
Basically from https://github.com/pgRouting/osm2pgrouting/blob/master/src/osm2pgrouting.cpp#L37
to L141 is to be “transformed” to use boost::program_options

Difficulty: Easy
Urgency: First things first. This is first
I would like Sarthak to define the help message for each option. I think it will help him understand why we require what we require. (some things are obvious, but what is obvious for me its not obvious for all), If he has questions then in the appropriate issue he can ask.

I am creating an ISSUE for each parameter we think we might use and make a reference to this issue.
All the issues/parameter can be worked in parallel.
Due to time constraints some of them are to be commented out for implementation in a future release.

This will give us a general skeleton. And if something at the end results redundant, not implemented, then we can just delete it or comment it out.

Use boost program Options.
http://www.boost.org/doc/libs/1_58_0/doc/html/program_options.html
some examples:
https://github.com/boostorg/program_options/tree/develop/example

I suggest that to any boost library that is going to be used, to gain experience:

  1. make a “fast read” to the boost documentation,
  2. copy 2 or 3 small examples and execute them as they are
  3. modify the examples a little, focusing on “how it could be integrated” into osm2pgrouting and “see what happens”
@cvvergara
Copy link
Member Author

For developing purposes in pgRouting we are using it here
https://github.com/pgRouting/pgrouting/blob/develop/src/ksp/src/mainP.cpp#L83

@sarthak0415
Copy link
Contributor

Read the documentation and coded the first phase. Code available on gsoc-develop branch

@cvvergara
Copy link
Member Author

@dkastl @woodbri @sarthak-0415
program_options shows the default, which do you think is best for the help message?
this:

  --prefixtables arg (=pgr_)            Add at the beginning of table names 
                                        (default: pgr_).

or:

  --prefixtables arg (=pgr_)            Add at the beginning of table names.

@sarthak0415
Copy link
Contributor

I think we should choose option 2 as showing the values twice is redundant

@cvvergara
Copy link
Member Author

I agree with @sarthak-0415 opinion.

@woodbri
Copy link

woodbri commented Jul 18, 2015

I agree also.

@dkastl
Copy link
Member

dkastl commented Jul 19, 2015

I agree as well.
But what about naming the prefix osm_ by default. Since it's OSM data.

robe2 added a commit to robe2/osm2pgrouting that referenced this issue Aug 9, 2015
robe2 added a commit to robe2/osm2pgrouting that referenced this issue Aug 9, 2015
…Schema as suggested by Vicky, add missing line), fix typos in config outputa
@cvvergara cvvergara added this to the osm2pgrouting 2.1.0 milestone Mar 20, 2016
@cvvergara cvvergara removed this from the osm2pgrouting 3.0.0 milestone Mar 20, 2016
@cvvergara
Copy link
Member Author

All the features requested in this discussion have being implemented in V2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants