Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch "connectors.postgis.DbError" exception #141

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

sanak
Copy link
Member

@sanak sanak commented Sep 18, 2022

Fixes #140.

Changes proposed in this pull request:

The issue's cause was catching parent dbConnector.DbError side, so I fixed to catch child connectors.postgis.DbError side with minimum import.
Also, I changed the log level from default Qgis.Info to Qgis.Critical for user's awareness.

@pgRouting/admins

@sanak sanak added the bug label Sep 18, 2022
@sanak sanak self-assigned this Sep 18, 2022
Copy link
Member

@cvvergara cvvergara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks simpler

@sanak
Copy link
Member Author

sanak commented Sep 20, 2022

@cvvergara, @cayetanobv (CC: @dkastl)
Thanks for approve !

This issue's original cause may be also my past bad code in QGIS v1 and v2 with Python2.

Anyway, I merge this once.

@sanak sanak merged commit aa41a12 into master Sep 20, 2022
@sanak sanak mentioned this pull request Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong catch exception class type in "reloadConnections" method
3 participants