Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C types reorganization and cleanup #2103

Merged
merged 26 commits into from Aug 28, 2021
Merged

C types reorganization and cleanup #2103

merged 26 commits into from Aug 28, 2021

Conversation

cvvergara
Copy link
Member

This is a follow up from #1893

  • Cleaned some C types that are duplicated
  • New general types: IID_t_rt II_t_rt I_rt`
    • I = Int64_t
    • D = double
  • Simplified names by removing pgr_
    • everything is pgrouting the prefix pgr_ historically comes from v1.x

@pgRouting/admins

@cvvergara
[c_types] General_Path_element_t -> Path_rt
fb27590
@cvvergara
[C/C++] General_Path_element_t -> Path_rt
ce676c8
@cvvergara
[c_types] Pgr_edge_xy_t -> Edge_xy_t
9178599
@cvvergara
[c_types] PickDeliveryOrders_t.h -> Orders_t
471eb97
@cvvergara
[c_types] Creating a double integer structure
4bf9a8e
@cvvergara
[C][coloring] Using Double_int_t_rt
98608af
@cvvergara
[C][makeConnected] Using Double_int_t_rt
42cc3fe
@cvvergara
[C][dominator] Using Double_int_t_rt
47677ef
@cvvergara
[C][coloring] Using Double_int_t_rt
16fd5d6
@cvvergara
[C][components] Using Double_int_t_rt
3b6c874
@cvvergara
[C][combinations] Using Double_int_t_rt
e28d7bb
@cvvergara
[c_types] pgr_flow_t -> Flow_t
e049f7d
@cvvergara
[c_types] pgr_flow_t -> Flow_t
8862c1d
@cvvergara
[c_types] Double_int64_t_rt -> II_t_rt
191eb54
@cvvergara
[c_types] matrix_cell_t.h -> iid_t_rt.h
0432da7
@cvvergara
[c_types] pgr_boyer_t -> IID_t_rt
bfc1f98
@cvvergara
[c_types] pgr_boyer_t -> IID_t_rt
691844a
@cvvergara
[c_types] pgr_costFlow_t -> CostFlow_t
b870a97
@cvvergara
[c_types] remove not used type
39a71f4
@cvvergara
[c_types] pgr_topologicalSort_t -> I_rt
0d7940a
@cvvergara
[c_types] pgr_topologicalSort_t -> I_rt
814dc4b
@cvvergara
[c_types] pgr_basic_edge_t -> Edge_bool_t_rt
cca48de
@cvvergara
[c_types] line_graph_rt -> edge_t
1fcb715
@cvvergara
[c_types][lint] geom_text_rt
50d225f
@cvvergara
[c_types] pgr_randomSpanningTree_t.h -> SpanTree_rt
8e743d1
@cvvergara cvvergara added this to the Release 3.3.0 milestone Aug 28, 2021
@cvvergara cvvergara self-assigned this Aug 28, 2021
krashish8
krashish8 approved these changes Aug 28, 2021
View reviewed changes
Copy link
Member

@krashish8 krashish8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Btw, is creating types like IID_t_rt a good idea? Although this generalizes the types, but simultaneously, it decreases the readability to someone who is not aware of what I and D denote.
Anyway, if we want to generalize, then that's a good way to do so, so it's okay.

@cvvergara cvvergara merged commit 95106da into pgRouting:develop Aug 28, 2021
@cvvergara
Copy link
Member Author

Yeah, needs documentation.

@cvvergara cvvergara deleted the renaming-c_types-try2 branch August 28, 2021 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krashish8 krashish8 krashish8 approved these changes

Assignees

@cvvergara cvvergara

Labels
Enhancement
Projects
None yet
Milestone
Release 3.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cvvergara @krashish8