Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]Doc/pgr_areaContraction #854

Merged
merged 13 commits into from
Jun 20, 2017
Merged

Conversation

thisisashukla
Copy link
Contributor

Fixes #32 .

Changes proposed in this pull request:

  • Added onetomany path images (However I am getting an error for those files)
  • Added to the proposal documentation

@pgRouting/admins

@cvvergara
Copy link
Member

I got this errors:
Did you get them in locally when you generated the documentation locally?

/home/vicky/pgrouting/pgrouting/pgrouting/build/doc/areaContraction.rst:83: WARNING: image file not readable: images/onetomany_a.png
/home/vicky/pgrouting/pgrouting/pgrouting/build/doc/areaContraction.rst:89: WARNING: image file not readable: images/onetomany_b.png
/home/vicky/pgrouting/pgrouting/pgrouting/build/doc/areaContraction.rst:95: WARNING: image file not readable: images/onetomany_c.png
/home/vicky/pgrouting/pgrouting/pgrouting/build/doc/areaContraction.rst:100: WARNING: image file not readable: images/onetomany_d.png
pgRouting-concepts.rst:3: SEVERE: Title level inconsistent:

Description of the return values for a path
...............................................................................

@cvvergara
Copy link
Member

you didnt configure all the images files (might be the reason for the "image not readable")
https://github.com/daas-ankur-shukla/pgrouting/blob/doc/areaC13/doc/areaContraction/images/CMakeLists.txt

@cvvergara
Copy link
Member

Your .png files have permission to execute, are you injecting a virus?

-rwxrwxr-x 

Fix that with

chmod -x *.png

the permissions should be:

-rw-rw-r--

@cvvergara
Copy link
Member

Remove the

documentation.sh
run_new.sh

From the .gitignore file

.gitignore is a file that affects all of us ...
For years I see my

decumentation.sh
run.sh

when I do a git status, just to make sure that I didn't add it to a commit.

Untracked files:
  (use "git add <file>..." to include in what will be committed)

        gsoc2017/
        publish.sh
        result.txt
        run.sh
        src/trsp/doc/
        steps.txt
        translate.sh
        try1.txt
        try2.txt
        try3.txt

Those files I want them untracked, but I want to be able to see what I haven't added to a commit.
so, if its not in the list:

  • because I deleted the file
  • or because its in the commit

now my documentation.sh does not show any more, doing an ls its there, and I didn't add it to a commit. you are making me ignore something that I don't want to ignore.

Copy link
Member

@cvvergara cvvergara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daas-ankur-shukla
work the changes in your working branch, then you push your working branch and make a PR to your C13 branch using the website, then you merge to C13 branch then I'll check how things look, because it will be automatically refrected to the PR you have to test/docG.

@cvvergara
Copy link
Member

I'll fix this error:

pgRouting-concepts.rst:3: SEVERE: Title level inconsistent:

Description of the return values for a path
...............................................................................

@thisisashukla
Copy link
Contributor Author

@cvvergara maam i have read the comments just now. doing the needful

@cvvergara cvvergara merged commit 78b986f into pgRouting:test/docG Jun 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants