Skip to content

Commit

Permalink
1) Fixed feature tests failed due to maintenance changes.
Browse files Browse the repository at this point in the history
2) Update release note.
  • Loading branch information
akshay-joshi committed Jul 27, 2023
1 parent 5c2d242 commit b4e6d8c
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 6 deletions.
1 change: 1 addition & 0 deletions docs/en_US/release_notes_7_6.rst
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ Bundled PostgreSQL Utilities
New features
************

| `Issue #6376 <https://github.com/pgadmin-org/pgadmin4/issues/6376>`_ - Added unlogged option while creating a sequence.
| `Issue #6381 <https://github.com/pgadmin-org/pgadmin4/issues/6381>`_ - Added support for SYSTEM, CONCURRENTLY and TABLESPACE options in REINDEX.
| `Issue #6397 <https://github.com/pgadmin-org/pgadmin4/issues/6397>`_ - Added new/missing options to the VACUUM command.
| `Issue #6415 <https://github.com/pgadmin-org/pgadmin4/issues/6415>`_ - Added SKIP_LOCKED and BUFFER_USAGE_LIMIT option to Analyze command.
Expand Down
17 changes: 11 additions & 6 deletions web/regression/feature_tests/pg_utilities_maintenance_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -130,13 +130,13 @@ def verify_command(self):
command = self.page.find_by_css_selector(
NavMenuLocators.process_watcher_detailed_command_css).text

vacuum_details = \
"VACUUM (VERBOSE) on database '{0}' of server " \
"{1} ({2}:{3})".format(self.database_name, self.server['name'],
self.server['host'], self.server['port'])
if self.test_level == 'database':
vacuum_details = \
"VACUUM on database '{0}' of server " \
"{1} ({2}:{3})".format(self.database_name, self.server['name'],
self.server['host'], self.server['port'])
self.assertEqual(message, vacuum_details)
self.assertEqual(command, "VACUUM VERBOSE;")
self.assertEqual(command, "VACUUM (VERBOSE);")
elif self.is_xss_check and self.test_level == 'table':
# Check for XSS in the dialog
source_code = self.page.find_by_css_selector(
Expand All @@ -148,8 +148,13 @@ def verify_command(self):
'Maintenance detailed window'
)
else:
vacuum_details = \
"VACUUM on table '{0}/public/{1}' of server " \
"{2} ({3}:{4})".format(self.database_name, self.table_name,
self.server['name'],
self.server['host'], self.server['port'])
self.assertEqual(message, vacuum_details)
self.assertEqual(command, "VACUUM VERBOSE"
self.assertEqual(command, "VACUUM (VERBOSE)"
" public." + self.table_name + ";")

test_gui_helper.close_process_watcher(self)
Expand Down

0 comments on commit b4e6d8c

Please sign in to comment.