Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all config options can be configured via env vars #29

Closed
szuliq opened this issue Nov 27, 2018 · 6 comments
Closed

Not all config options can be configured via env vars #29

szuliq opened this issue Nov 27, 2018 · 6 comments

Comments

@szuliq
Copy link

szuliq commented Nov 27, 2018

Why some config options are being read from env vars and some are not?

I really liked the fact I can configure collector via env vars on Docker. The joy ended when I wanted to set db_log_location.

Please make all options configurable via env vars.

@LifeMoroz
Copy link

The same question.
Im using pg analyze with Docker-Compose and it is very painful to return on config-files

@mgood
Copy link

mgood commented Nov 28, 2018

Agreed, it would be nice if the environment keys were derived automatically from the ini tags so that they were always in-sync.

I'd also like the ability to configure multiple dbs via the environment. That could be split into a separate issue if it adds too much complexity to implement at once. For example something like:

DB_HOST[foo]=foo.rds...
DB_HOST[bar]=bar.rds...

@lfittl
Copy link
Member

lfittl commented Nov 30, 2018

This is all good feedback, and will give this some more thought how multiple DBs can be supported.

For the main issue initially reported (db_log_location) I pushed a fix yesterday (515202d) and will stamp a new release in the next few days.

Would it be useful if the regular config file format was accepted by the Docker container? (i.e. the full size config file as an env variable, or mounted in as a volume?)

@szuliq
Copy link
Author

szuliq commented Nov 30, 2018 via email

@lfittl
Copy link
Member

lfittl commented Nov 30, 2018

@szuliq Good point, you are indeed correct that this already works :)

@lfittl
Copy link
Member

lfittl commented Jan 1, 2019

Closing this since the LOG_LOCATION environment variable is now available in version 0.17.1 (v0.17.1 tag on docker).

@lfittl lfittl closed this as completed Jan 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants