Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use query ID cache to skip query fingerprint calculation #346

Closed
wants to merge 3 commits into from
Closed

Use query ID cache to skip query fingerprint calculation #346

wants to merge 3 commits into from

Conversation

seanlinsley
Copy link
Member

@seanlinsley seanlinsley commented Dec 16, 2022 •
edited
Loading

Query fingerprinting takes around half of GetStatements runtime (0.9 of 1.9 seconds in the below pprof screenshot). Since #339 adds a query_id/fingerprint cache, we can rely on that to skip this expensive step.

Screenshot 2022-12-16 at 9 23 40 AM

@seanlinsley seanlinsley requested a review from a team December 16, 2022 21:24
@seanlinsley seanlinsley mentioned this pull request Dec 16, 2022
Closed
@lfittl lfittl mentioned this pull request Dec 21, 2022
Open
lfittl
lfittl approved these changes Mar 3, 2023
View reviewed changes
Copy link
Member

@lfittl lfittl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good - if we can complete #339 first that would be good, but I don't see a reason to not merge this as well.

@seanlinsley seanlinsley deleted the fingerprint-cache-perf branch June 22, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lfittl lfittl lfittl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seanlinsley @lfittl