Add integrity checks before uploading snapshots #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are there any other full snapshot checks we should make? I didn't see any similar checks to make for compact snapshots, but maybe I missed something. |
lfittl
reviewed
Mar 25, 2023
The snapshot format makes some structural assumptions that cannot be enforced by protobuf. If these are violated, processing the snapshot may fail, or snapshot data may be misinterpreted and can cause bogus statistics to be recorded. Validate these assumptions before sending a snapshot.
This reverts commit 867b45b.
msakrejda
force-pushed
the
add-snapshot-integrity-checks
branch
from
77a7709
to
d851aa6
Compare
This could cause problems for subsequent snapshot computations. Instead, just log an error and send a failed snapshot.
msakrejda
commented
Mar 28, 2023
| } | ||
|
|
||
| func SendFailedFull(ctx context.Context, server *state.Server, collectionOpts state.CollectionOpts, logger *util.Logger) error { | ||
| s := snapshot.FullSnapshot{FailedRun: true, CollectorErrors: logger.ErrorMessages} | ||
| s := snapshot.FullSnapshot{FailedRun: true} |
There was a problem hiding this comment.
I ended up moving this into submitFull because both callers were setting collector errors independently before invoking that helper--we might as well do it in the shared code path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The snapshot format makes some structural assumptions that cannot be
enforced by protobuf. If these are violated, processing the snapshot
may fail, or snapshot data may be misinterpreted and can cause bogus
statistics to be recorded.
Validate these assumptions before sending a snapshot.
See discussion in #399 (review)