Makefile: Use -Wall for compiling tests #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CFLAGS uses -Wall along with some -Wno-* options. However, tests are compiled using TEST_CFLAGS, so they did not use these options. Compile tests with -Wall. This also reorders the TEST_CFLAGS options to match the CFLAGS options above for easier comparison. test/concurrency: Fix unused arg warning from -Wall. Sort includes.
lfittl
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
👍 Seems reasonable, thanks for the contribution!
Note that we intentionally don't check for some warnings for the main library code (since Postgres itself isn't warning free), but the compilation flags for those units uses CFLAGS, not TEST_CFLAGS, so we are good in that regard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CFLAGS uses -Wall along with some -Wno-* options. However, tests are compiled using TEST_CFLAGS, so they did not use these options. Compile tests with -Wall. This also reorders the TEST_CFLAGS options to match the CFLAGS options above for easier comparison.
test/concurrency: Fix unused arg warning from -Wall. Sort includes.
Feel free to reject this pull request since it doesnt really change anything. I just noticed it while making another change to the tests.