Drop Init_pg_query from exported symbol map
#256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanhu
force-pushed
the
sh-drop-exported-symbol
branch
from
dc219ef
to
6962a62
Compare
|
@lfittl macOS 12.6 fixes a zero-day vulnerability, and it appears that XCode 14 tends to be upgraded with that. I think this fix might be needed soon as more people start to use a Ruby interpreter compiled under XCode 14. |
|
@stanhu Hmm, I think this may require some more thinking, because the symbol name without the Since we already have a special case for |
stanhu
force-pushed
the
sh-drop-exported-symbol
branch
from
6962a62
to
48bad9f
Compare
stanhu
changed the title
Init_pg_query from exported symbol mapInit_pg_query from exported symbol map for macOS builds
stanhu
force-pushed
the
sh-drop-exported-symbol
branch
from
48bad9f
to
ca0b260
Compare
`Init_pg_query` isn't actually exported, but `_Init_pg_query` is:
```
% nm pg_query_ruby.o | grep Init
0000000000000000 T _Init_pg_query
0000000000003b40 b _Init_pg_query.rb_intern_id_cache
```
A Ruby compiler compiled with XCode 14 without the flag
`-undefined,dynamic_lookup` will see this error:
```
linking shared-object pg_query/pg_query.bundle
Undefined symbols for architecture arm64:
"Init_pg_query", referenced from:
-exported_symbol[s_list] command line option
(maybe you meant: _Init_pg_query)
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [pg_query.bundle] Error 1
```
In pganalyze#222, FreeBSD needed `Init_pg_query`, so we uses a specific symbol
map file for FreeBSD.
Closes pganalyze#255
stanhu
force-pushed
the
sh-drop-exported-symbol
branch
from
ca0b260
to
efda1d5
Compare
|
@lfittl Ah, thanks. I should have looked at the history to see that. I added a FreeBSD symbol file. |
stanhu
changed the title
Init_pg_query from exported symbol map for macOS buildsInit_pg_query from exported symbol map
lfittl
approved these changes
Sep 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Init_pg_queryisn't actually exported, but_Init_pg_queryis:A Ruby compiler compiled with XCode 14 without the flag
-undefined,dynamic_lookupwill see this error:In #222, FreeBSD needed
Init_pg_query, so we uses a specific symbol map file for FreeBSD.Closes #255