Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Init_pg_query from exported symbol map #256

Merged
merged 1 commit into from Sep 17, 2022

Commits on Sep 17, 2022

  1. Drop Init_pg_query from exported symbol map

    `Init_pg_query` isn't actually exported, but `_Init_pg_query` is:
    
    ```
    % nm pg_query_ruby.o | grep Init
    0000000000000000 T _Init_pg_query
    0000000000003b40 b _Init_pg_query.rb_intern_id_cache
    ```
    
    A Ruby compiler compiled with XCode 14 without the flag
    `-undefined,dynamic_lookup` will see this error:
    
    ```
    linking shared-object pg_query/pg_query.bundle
    Undefined symbols for architecture arm64:
      "Init_pg_query", referenced from:
         -exported_symbol[s_list] command line option
         (maybe you meant: _Init_pg_query)
    ld: symbol(s) not found for architecture arm64
    clang: error: linker command failed with exit code 1 (use -v to see invocation)
    make: *** [pg_query.bundle] Error 1
    ```
    
    In pganalyze#222, FreeBSD needed `Init_pg_query`, so we uses a specific symbol
    map file for FreeBSD.
    
    Closes pganalyze#255
    stanhu committed Sep 17, 2022
    Configuration menu
    Copy the full SHA
    efda1d5 View commit details
    Browse the repository at this point in the history