Feature proxy object #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Create README-vi.md file Translated the readme text from English to Vietnamese * Added link to README.md * Added link to README-vi.md
Merge branch 'hotfix/1.0.5'
pgaref
reviewed
Jun 26, 2017
| @@ -0,0 +1,6 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
We should avoid commit files under .idea folder - A nice way to achieve that is using .gitignore file
pgaref
reviewed
Jun 26, 2017
| @@ -0,0 +1,11 @@ | |||
| class ProxyObject(object): | |||
There was a problem hiding this comment.
Looks good, we have all the attributes we need for now
pgaref
reviewed
Jun 26, 2017
| @@ -46,6 +47,15 @@ def parse_proxyList(self): | |||
| # Make sure it is a Valid Proxy Address | |||
| if UrlParser.valid_ip_port(td_row.text): | |||
| curr_proxy_list.append('http://' +td_row.text) | |||
| proxy_object = ProxyObject() | |||
There was a problem hiding this comment.
Looks good, we probably want to make the code more clear and move this chunk of code in a separate method which returns a ProxyObject
pgaref
reviewed
Jun 26, 2017
| @@ -45,12 +46,20 @@ def parse_proxyList(self): | |||
| break | |||
| else: | |||
| address += field[1] + ':' | |||
| proxy_object = ProxyObject() | |||
There was a problem hiding this comment.
Good, we probably should move the code to a separate method (check below)
pgaref
reviewed
Jun 26, 2017
| @@ -49,12 +50,20 @@ def parse_proxyList(self): | |||
| break | |||
| else: | |||
| address += field[1] + ':' | |||
| proxy_object = ProxyObject() | |||
There was a problem hiding this comment.
Good, we probably should move the code to a separate method (check below)
pgaref
reviewed
Jun 26, 2017
| @@ -33,6 +34,12 @@ def parse_proxyList(self, use_top15k=False): | |||
| if UrlParser.valid_ip_port(row): | |||
| proxy = "http://" + row | |||
| curr_proxy_list.append(proxy.__str__()) | |||
| proxy_object = ProxyObject() | |||
There was a problem hiding this comment.
Good, we probably should move the code to a separate method (check below)
pgaref
approved these changes
Jun 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.