Skip to content
This repository has been archived by the owner on Aug 5, 2023. It is now read-only.

Update novnc_generate.go #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ValentinBossi
Copy link

to use newer version of novnc
for examlpe to use quality param of novnc to set image quality

@ValentinBossi
Copy link
Author

hm master is on v1.2. but how can i pass the quality param to novnc?

@pgaskin
Copy link
Owner

pgaskin commented Feb 16, 2021

Thanks!

Note that I'll need to get around to updating the password mechanism so connections without a password still work correctly (and so it doesn't go into the browser history).

but how can i pass the quality param to novnc?

It would need to be added to the main page.

@ValentinBossi
Copy link
Author

ValentinBossi commented Mar 2, 2021

sadly im not a go engineer🤦🏼‍♂️
i followed your guide on digital ocean. i edited supervisord.conf and extended the part command=/usr/local/bin/easy-novnc --addr :8080 --host localhost --port 5900 --no-url-password --novnc-params "resize=remote" with quality but then it fails...

command=/usr/local/bin/easy-novnc --addr :8080 --host localhost --port 5900 --no-url-password --novnc-params "resize=remote,qualityLevel=9"

Xvnc TigerVNC 1.9.0 - built Sep 29 2020 18:21:20
Copyright (C) 1999-2018 TigerVNC Team and many others (see README.rst)
See http://www.tigervnc.org for information on TigerVNC.
Underlying X server release 12004000, The X.Org Foundation



Sat Feb 13 22:59:23 2021
 vncext:      VNC extension running!
 vncext:      Listening for VNC connections on local interface(s), port 5900
 vncext:      created VNC server for screen 0
Error: error parsing noVNC params: unknown option "qualityLevel".
2021-02-13 22:59:23,091 INFO exited: easy-novnc (exit status 2; not expected)
2021-02-13 22:59:23,091 INFO exited: easy-novnc (exit status 2; not expected)

@pgaskin
Copy link
Owner

pgaskin commented Mar 3, 2021

with quality but then it fails

That's a separate option, and by default, it's only controllable via the noVNC UI. I'd need to rework the way parameters are handled to be able to have this specified on the command line. This is planned for a future version.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants