Skip to content

Commit

Permalink
Document maximum version for auto-stop option.
Browse files Browse the repository at this point in the history
  • Loading branch information
Brad Nicholson authored and dwsteele committed Oct 3, 2019
1 parent 008ec6b commit 887ec97
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 0 deletions.
2 changes: 2 additions & 0 deletions doc/xml/reference.xml
Original file line number Diff line number Diff line change
Expand Up @@ -606,6 +606,8 @@

This feature relies on pg_is_in_backup() so only works on <postgres/> >= <id>9.3</id>.

This feature is not supported for <postgres/> >= <id>9.6</id> since backups are run in non-exclusive mode.

The setting is disabled by default because it assumes that <backrest/> is the only process doing exclusive online backups. It depends on an advisory lock that only <backrest/> sets so it may abort other processes that do exclusive online backups. Note that <cmd>base_backup</cmd> and <cmd>pg_dump</cmd> are safe to use with this setting because they do not call <code>pg_start_backup()</code> so are not exclusive.</text>

<example>y</example>
Expand Down
12 changes: 12 additions & 0 deletions doc/xml/release.xml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,18 @@

<release-list>
<release date="XXXX-XX-XX" version="2.19dev" title="UNDER DEVELOPMENT">
<release-doc-list>
<release-improvement-list>
<release-item>
<release-item-contributor-list>
<release-item-contributor id="brad.nicholson"/>
</release-item-contributor-list>

<p>Document maximum version for <br-option>auto-stop</br-option> option.</p>
</release-item>
</release-improvement-list>
</release-doc-list>

</release>

<release date="2019-10-01" version="2.18" title="PostgreSQL 12 Support">
Expand Down
2 changes: 2 additions & 0 deletions src/config/define.auto.c
Original file line number Diff line number Diff line change
Expand Up @@ -4382,6 +4382,8 @@ static ConfigDefineOptionData configDefineOptionData[] = CFGDEFDATA_OPTION_LIST
"\n"
"This feature relies on pg_is_in_backup() so only works on PostgreSQL >= 9.3.\n"
"\n"
"This feature is not supported for PostgreSQL >= 9.6 since backups are run in non-exclusive mode.\n"
"\n"
"The setting is disabled by default because it assumes that pgBackRest is the only process doing exclusive online "
"backups. It depends on an advisory lock that only pgBackRest sets so it may abort other processes that do "
"exclusive online backups. Note that base_backup and pg_dump are safe to use with this setting because they do not "
Expand Down

0 comments on commit 887ec97

Please sign in to comment.