Enable -Wswitch-enum and silence new warnings.

pgbackrest · Feb 26, 2018 · f9c1a3b · f9c1a3b
1 parent c8df690
commit f9c1a3b
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 4 deletions.
diff --git a/doc/xml/release.xml b/doc/xml/release.xml
@@ -22,6 +22,10 @@
 
                         <p>Fix incorrect enum types in <file>config.c</file> that throw warnings under clang.</p>
                     </release-item>
+
+                    <release-item>
+                        <p>Enable <id>-Wswitch-enum</id> and silence new warnings.</p>
+                    </release-item>
                 </release-development-list>
             </release-core-list>
         </release>

diff --git a/src/Makefile b/src/Makefile
@@ -17,7 +17,7 @@ COPT = -O2
 CINCLUDE = -I.
 
 # Compile warnings
-CWARN = -Wfatal-errors -Wall -Wextra -Wwrite-strings -Wno-clobbered
+CWARN = -Wfatal-errors -Wall -Wextra -Wwrite-strings -Wno-clobbered -Wswitch-enum
 
 # Automatically generate Perl compile options for the local system
 CPERL = `perl -MExtUtils::Embed -e ccopts`

diff --git a/src/common/type/variant.c b/src/common/type/variant.c
@@ -165,7 +165,8 @@ varEq(const Variant *this1, const Variant *this2)
                     break;
                 }
 
-                default:
+                case varTypeKeyValue:
+                case varTypeVariantList:
                     THROW(AssertError, "unable to test equality for %s", variantTypeName[this1->type]);
             }
         }
@@ -634,7 +635,8 @@ varStrForce(const Variant *this)
             break;
         }
 
-        default:
+        case varTypeKeyValue:
+        case varTypeVariantList:
             THROW(FormatError, "unable to force %s to %s", variantTypeName[this->type], variantTypeName[varTypeString]);
     }
 

diff --git a/src/config/parse.c b/src/config/parse.c
@@ -539,7 +539,10 @@ configParse(int argListSize, const char *argList[])
                                         }
 
                                         // Other types are output plain
-                                        default:
+                                        case cfgDefOptTypeFloat:
+                                        case cfgDefOptTypeHash:
+                                        case cfgDefOptTypeInteger:
+                                        case cfgDefOptTypeList:
                                         {
                                             strLstAddZ(dependValueList, dependValue);   // {uncovered - no depends of other types}
                                             break;                                      // {+uncovered}