Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Postgres 16beta1 Support #1169

Merged
merged 22 commits into from Jun 16, 2023
Merged

Postgres 16beta1 Support #1169

merged 22 commits into from Jun 16, 2023

Conversation

eeeebbbbrrrr
Copy link
Contributor

@eeeebbbbrrrr eeeebbbbrrrr commented Jun 15, 2023 •
edited

This lands support for Postgres 16beta1. It does it in such a way that it won't be a gigantic pain in the ass to soon add support for subsequent betas and release candidates.

It's understood by the codebase as just "pg16", so we won't be able to support, say, beta1, beta2, and rc1 concurrently, but that's okay. That sounds terrible anyhow.

There were a few internal pgrx changes to fix compatibility and get tests passing, but nothing major.

Note that the GucSettings for strings have changed from GucSetting<Option<&'static str>> to GucSetting<Option<&'static CStr>> because the latter is what they really are.

A note to whomever might merge this PR... I think it would be better to do a regular merge here, rather than a squash merge. There's only 3 commits (so far), and I think I'd prefer to see those reflected as such in the git history. EDIT: ehh, lets squash-merge this -- many more commits now.

@eeeebbbbrrrr
Get cargo-pgrx capable of downloading/installing v16beta1. `build.r…
f260928 
…s` is now probably capable of understanding `pg16` too, but that's untested at the moment.
@eeeebbbbrrrr
pg16 bindings generate and repo passes cargo check --all without er…
8533092 
…rors or warnings.

Tests fail for some reason.
@eeeebbbbrrrr
Fix all test failures for pg16
79a8410 
- re-implement `GucSetting` to use an opaque usize, so that it can be compatible with all pg version.  16 requires the setting pointer value to be the same as the "boot_value" when defining a new GUC -- older versions didn't care about that.

- with the above, string `GucSetting`s are now `GucSetting<Option<&'static CStr>>` instead of `&str` because they're actually CStrings.

- pg16 exposes the previously private `GetMemoryChunkContext()` function, so we use it in our backwards named `GetMemoryContextChunk()` function.  :/

- Use our existing `regtypein()` function instead of `parseTypeString()`

- Add a version of `get_timezone_offset()` for pg16

- pg16 got rid of the `postmaster` symlink, so use `postgres` in that case -- we could just use that for everything but I decided to be explicit that it changed
@eeeebbbbrrrr
Copy link
Contributor Author

Need to figure out CI support for 16beta1.

workingjubilee
workingjubilee reviewed Jun 15, 2023
View reviewed changes
Copy link
Member

@workingjubilee workingjubilee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to examine the GetMemoryChunkContext stuff more closely, but I had a few nits and a question that are independent.

cargo-pgrx/src/command/init.rs Outdated Show resolved Hide resolved
pgrx-pg-config/src/lib.rs Outdated Show resolved Hide resolved
pgrx-pg-config/src/lib.rs Outdated Show resolved Hide resolved
cargo-pgrx/src/command/version.rs Outdated Show resolved Hide resolved
cargo-pgrx/src/command/version.rs Outdated Show resolved Hide resolved
pgrx-pg-config/src/lib.rs Show resolved Hide resolved
pgrx-pg-sys/src/lib.rs Outdated Show resolved Hide resolved
pgrx/src/datum/range.rs Outdated Show resolved Hide resolved
pgrx/src/guc.rs Outdated Show resolved Hide resolved
pgrx/src/tupdesc.rs Show resolved Hide resolved
@eeeebbbbrrrr
Copy link
Contributor Author

I need to examine the GetMemoryChunkContext stuff more closely, but I had a few nits and a question that are independent.

I've addressed everything that you mentioned here. All good catches, thanks a bunch!

As far as the MemoryContextChunk business, it's actually simple for pg16... it's the other versions where we had to port their static inline function to Rust (which I did last year, so that code has been around for awhile). For reference, here's where it came from: https://github.com/postgres/postgres/blob/4be308edee4495fe72075397efa0f6e0e0f9693b/src/include/utils/memutils.h#L114

workingjubilee
workingjubilee approved these changes Jun 16, 2023
View reviewed changes
Copy link
Member

@workingjubilee workingjubilee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR includes breaking changes, but aside from that, seems good to me.

@eeeebbbbrrrr eeeebbbbrrrr merged commit efff208 into develop Jun 16, 2023
8 checks passed
@eeeebbbbrrrr eeeebbbbrrrr deleted the pg16-support branch June 20, 2023 17:59
@eeeebbbbrrrr eeeebbbbrrrr mentioned this pull request Jul 8, 2023
Merged
@eeeebbbbrrrr eeeebbbbrrrr mentioned this pull request Sep 5, 2023
Merged
eeeebbbbrrrr added a commit that referenced this pull request Sep 5, 2023
@eeeebbbbrrrr
Update version to 0.10.0 (#1280)
3d1c8e3 
This is the final release of v0.10.0. Thanks everyone for the beta
testing, pull requests, issues, and patience.

As always, install `cargo-pgrx` with `cargo install cargo-pgrx --locked`
and update your extension Cargo.toml files to use the `0.10.0` pgrx
dependencies.

This release includes support for Postgres 16RC1. Support for the
previous betas has been removed. As such, a fresh `cargo pgrx init` is
required.

## What's Changed Since v0.10.0-beta.4

* Fix `GetMemoryChunkContext` port by @workingjubilee in
#1273
* Better error messages when `pg_config` isn't found. by @eeeebbbbrrrr
in #1271
* Make `PostgresHash` also need `Eq` by @workingjubilee in
#1264
* Memoize git hash and extension metadata by @levkk in
#1274
* move to pg16rc1 by @eeeebbbbrrrr in
#1276
* Fix bgworker template up to 0.10.0-beta.4 by @workingjubilee in
#1270

## New Contributors
* @levkk made their first contribution in
#1274

**Changelog**:
v0.10.0-beta.4...v0.10.0

---

v0.10.0's full set of changes throughout the entire beta period are:

* Postgres 16beta1 Support by @eeeebbbbrrrr in
#1169
* Support building against macOS universal binaries by @clowder in
#1166
* list specific versions in feature gates by @eeeebbbbrrrr in
#1175
* Fix bug with converting a `pg_sys::Datum` into a `pgrx::Date` by
@eeeebbbbrrrr in #1177
* Fix Arrays with leading nulls by @eeeebbbbrrrr in
#1180
* Disable hello_versioned_so test by @workingjubilee in
#1192
* doc: fix link broken by @yihong0618 in
#1181
* fcinfo: fix incorrect length set in unsafe code by @Sasasu in
#1190
* update to pg16beta2 support by @eeeebbbbrrrr in
#1188
* Array-walking is aligned by @workingjubilee in
#1191
* Implement PGRXSharedMemory for Deque by @feikesteenbergen in
#1170
* Include security labels header by @daamien in
#1189
* Fixes macos-11 tests by @BradyBonnette in
#1197
* Pgcentralfoundation updates again by @eeeebbbbrrrr in
#1200
* Update version to 0.10.0-beta.0 by @eeeebbbbrrrr in
#1201
* Testing help by @eeeebbbbrrrr in
#1203
* Type testability cleanup by @eeeebbbbrrrr in
#1204
* Try to smartly propagate fs errors by @workingjubilee in
#1186
* Fix issue #1209 by @eeeebbbbrrrr in
#1210
* Type roundtrip tests by @eeeebbbbrrrr in
#1185
* Update version to 0.10.0-beta.1 by @eeeebbbbrrrr in
#1213
* Add a workaround for the pg16/homebrew/icu4c situation by @thomcc in
#1206
* Add security policy by @johnrballard in
#1207
* `AnyNumeric` is no longer backed by Postgres-allocated memory by
@eeeebbbbrrrr in #1216
* Modularize pgrx::spi by @workingjubilee in
#1219
* Stop SpiClient soundness from regressing by @workingjubilee in
#1214
* Add foreign table headers by @workingjubilee in
#1226
* Modularize the interior of pgrx-pg-sys by @workingjubilee in
#1227
* Initial valgrind support by @thomcc in
#1218
* Add support for handling SIGINT and SIGCHLD from bgworker by @JelteF
in #1229
* Ignores UI tests for MUSL environments by @BradyBonnette in
#1235
* Add a env flag that can be set to skip `#[pg_test]`-generated tests.
by @thomcc in #1239
* Fix issue #1076: Properly handle dependency graph of `Result<T, _>` by
@eeeebbbbrrrr in #1241
* Cleanup the error when cargo-pgrx version doesn't match Cargo.toml by
@eeeebbbbrrrr in #1240
* Add operator and cache related api by @VoVAllen in
#1242
* Addresses cargo-pgrx error reporting by @BradyBonnette in
#1238
* Update version to 0.10.0-beta.2 by @eeeebbbbrrrr in
#1244
* Bump cargo-metadata and clap-cargo by @thomcc in
#1246
* Derive Clone for Inet by @JelteF in
#1251
* Correct docs for datetime `From` impls by @workingjubilee in
#1253
* Only enable line tables for profile.dev by @thomcc in
#1249
* Remove references to master branch by @thomcc in
#1243
* Ensure bindgen gets all the `cppflags` it needs (on macOS, anyway) by
@thomcc in #1247
* update for pg16beta3 support by @eeeebbbbrrrr in
#1254
* Update version to 0.10.0-beta.3 by @eeeebbbbrrrr in
#1255
* Add proptest support by @workingjubilee in
#1258
* Misc reformatting and typo fixes by @workingjubilee in
#1260
* spi: simplify (optimize?) Datum preparation by @vrmiguel in
#1256
* Assume commutation when deriving PostgresEq by @workingjubilee in
#1261
* Demand Ord for PostgresOrd by @workingjubilee in
#1262
* Fix pgrx install causing postgresql coredump by @Sasasu in
#1263
* Update version to 0.10.0-beta.4 by @workingjubilee in
#1267

## New Contributors
* @clowder made their first contribution in
#1166
* @yihong0618 made their first contribution in
#1181
* @Sasasu made their first contribution in
#1190
* @daamien made their first contribution in
#1189
* @johnrballard made their first contribution in
#1207
* @VoVAllen made their first contribution in
#1242
* @vrmiguel made their first contribution in
#1256


**Full Changelog**:
v0.9.8...v0.10.0
@bayandin bayandin mentioned this pull request Sep 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@workingjubilee workingjubilee workingjubilee approved these changes

@thomcc thomcc Awaiting requested review from thomcc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eeeebbbbrrrr @workingjubilee @BradyBonnette