-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix missing trailing "]" and italic opening brackets in doc #840
Conversation
Inside shortverb, 1. If it contains "=" and ends with "]", this "]" is missing from output. E.g., "|[key=val]|" produces "[key=val". Change the input to "|[key=val||]|". 2. If it contains "=<opening bracket>", this bracket is typeset in italic. E.g., "|a={...}|" produces "a=<italic {>...}". Change the input to "|a=||{...}|".
Sorry, but I think I have to reject this pull request. First of all, it seems that you are not using the latest master to compile your example, because for me it renders like this, without missing closing delimiters. The fact that italics are not used for the closing delimiter is something that I am aware of and plan to fix in the future (cf. #831). You propose to typeset the right-hand side of assignments in upright font, but you are not being consistent ( |
Yes you are right. I used the latest master but didn't set pgf repo as a texlive usertree. Following the instructions in https://github.com/pgf-tikz/pgf#development, the missing trailing "]" problem disappears. So sorry. By the way, not directly related to this pr, there are still two typos I found in doc: First one, pgf/doc/generic/pgf/text-en/pgfmanual-en-library-circuits.tex Lines 87 to 128 in 357bc05
This Overfull \hbox (226.97084pt too wide) in paragraph at lines 87--129 Second one, pgf/doc/generic/pgf/text-en/pgfmanual-en-tikz-scopes.tex Lines 361 to 380 in 357bc05
The example uses option |
Inside shortverb,
If it contains "=" and ends with "]", this "]" is missing from output.
E.g., "|[key=val]|" produces "[key=val".
Change the input to "|[key=val||]|".
If it contains "=", this bracket is typeset in italic.
E.g., "|a={...}|" produces "a=<italic {>...}".
Change the input to "|a=||{...}|".
The first kind of change is rather complete, but for the second kind,
I only checked contents of every
quote
environment.There is already a case of second kind in the source code:
pgf/doc/generic/pgf/text-en/pgfmanual-en-tikz-shapes.tex
Lines 2404 to 2408 in 357bc05
Locally on my computer, I use a simplified
pgfmanual.tex
to test and compare: