Skip to content
This repository has been archived by the owner on Feb 28, 2021. It is now read-only.

Patch 2nd try and fix small sample config typo #25

Merged
merged 2 commits into from
Jul 4, 2018
Merged

Patch 2nd try and fix small sample config typo #25

merged 2 commits into from
Jul 4, 2018

Conversation

lulol
Copy link
Contributor

@lulol lulol commented Jun 25, 2018

  1. The previous fix was incomplete since mistakenly only corrected the line count for the external patch so it doesn't get truncated the first time, but that was not enough.

The last internal patch, even now complete, still creates a truncated file when applied the second time because also needs to be adjusted, (the actual line count is 47 and not 46)

  1. A couple of comment lines in bcm63xx_phone.conf.sample start with : instead of ;

The previous fix was incomplete since it only corrected the line count for the external patch so it doesn't get truncated the first time.

The last internal patch, even now complete, still creates a truncated file when applied the second time because also needs to be adjusted, (the actual line count is 47 and not 46)
A couple of comment lines start with : instead of the required ;
@pgid69
Copy link
Owner

pgid69 commented Jul 4, 2018

Thank you.
This time i took time to test the patch and it's ok for me.
BR

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants