Skip to content

Commit

Permalink
Missing fix for datastax#152. Bookie Service also needs the prefix on…
Browse files Browse the repository at this point in the history
… the port name (datastax#172)

Fixes datastax#158 (This is the second PR - see also apache/pulsar-helm-chart#162)

### Motivation

* All non-standard port-names need a proper protocol prefix to support Istio
 https://istio.io/latest/docs/ops/configuration/traffic-management/protocol-selection/#explicit-protocol-selection
 
### Modifications

Add the prefix value before `bookie`
  • Loading branch information
frankjkelly committed Nov 9, 2021
1 parent 5b10f48 commit 6173081
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion charts/pulsar/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ apiVersion: v1
appVersion: "2.7.2"
description: Apache Pulsar Helm chart for Kubernetes
name: pulsar
version: 2.7.3
version: 2.7.4
home: https://pulsar.apache.org
sources:
- https://github.com/apache/pulsar
Expand Down
2 changes: 1 addition & 1 deletion charts/pulsar/templates/bookkeeper-service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ metadata:
{{- end }}
spec:
ports:
- name: bookie
- name: "{{ .Values.tcpPrefix }}bookie"
port: {{ .Values.bookkeeper.ports.bookie }}
- name: http
port: {{ .Values.bookkeeper.ports.http }}
Expand Down

0 comments on commit 6173081

Please sign in to comment.